Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test) remove Go module for xDS test client #2280

Merged
merged 1 commit into from
Jul 5, 2021
Merged

chore(test) remove Go module for xDS test client #2280

merged 1 commit into from
Jul 5, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Jul 4, 2021

Summary

Remove Go module for xDS test client.

Full changelog

N/A

Issues resolved

This updates #2200.

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

This updates #2200.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach requested a review from a team as a code owner July 4, 2021 23:07
@jpeach
Copy link
Contributor Author

jpeach commented Jul 4, 2021

Looks like some Envoy v2 dependencies still here:

$ make run -C ./pkg/test/xds/client
make: Entering directory '/home/jpeach/upstream/konghq/kuma/pkg/test/xds/client'
go run main.go run --total "10" --xds-server-address "grpcs://localhost:5678"
2021-07-05T09:07:02.908+1000	INFO	kuma-xds-client.run	going to start xDS clients (Envoy simulators)	{"total": 10}
2021-07-05T09:07:02.908+1000	INFO	kuma-xds-client.run.envoy-simulator	creating an xDS client ...	{"idx": 0, "ID": "default.dataplane-0"}
2021-07-05T09:07:02.908+1000	INFO	kuma-xds-client.run.envoy-simulator	creating an xDS client ...	{"idx": 1, "ID": "default.dataplane-1"}
2021-07-05T09:07:02.908+1000	INFO	kuma-xds-client.run.envoy-simulator	creating an xDS client ...	{"idx": 2, "ID": "default.dataplane-2"}
2021-07-05T09:07:02.908+1000	INFO	kuma-xds-client.run.envoy-simulator	creating an xDS client ...	{"idx": 3, "ID": "default.dataplane-3"}
2021-07-05T09:07:02.908+1000	INFO	kuma-xds-client.run.envoy-simulator	creating an xDS client ...	{"idx": 4, "ID": "default.dataplane-4"}
2021-07-05T09:07:02.908+1000	INFO	kuma-xds-client.run.envoy-simulator	creating an xDS client ...	{"idx": 5, "ID": "default.dataplane-5"}
2021-07-05T09:07:02.908+1000	INFO	kuma-xds-client.run.envoy-simulator	creating an xDS client ...	{"idx": 6, "ID": "default.dataplane-6"}
2021-07-05T09:07:02.908+1000	INFO	kuma-xds-client.run.envoy-simulator	creating an xDS client ...	{"idx": 7, "ID": "default.dataplane-7"}
2021-07-05T09:07:02.909+1000	INFO	kuma-xds-client.run.envoy-simulator	creating an xDS client ...	{"idx": 8, "ID": "default.dataplane-8"}
2021-07-05T09:07:02.909+1000	INFO	kuma-xds-client.run.envoy-simulator	creating an xDS client ...	{"idx": 9, "ID": "default.dataplane-9"}
2021-07-05T09:07:04.880+1000	INFO	kuma-xds-client.run.envoy-simulator	opening an xDS stream ...	{"idx": 8, "ID": "default.dataplane-8"}
2021-07-05T09:07:04.888+1000	INFO	kuma-xds-client.run.envoy-simulator	requesting Listeners	{"idx": 8, "ID": "default.dataplane-8"}
2021-07-05T09:07:04.889+1000	INFO	kuma-xds-client.run.envoy-simulator	closing an xDS stream ...	{"idx": 8, "ID": "default.dataplane-8"}
2021-07-05T09:07:04.889+1000	INFO	kuma-xds-client.run.envoy-simulator	closing a connection ...	{"idx": 8, "ID": "default.dataplane-8"}
Error: one of xDS clients (Envoy simulators) terminated with an error: failed to request "type.googleapis.com/envoy.api.v2.Listener": EOF

@codecov-commenter
Copy link

Codecov Report

Merging #2280 (9508897) into master (cc0cb70) will increase coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2280      +/-   ##
==========================================
+ Coverage   51.69%   51.79%   +0.09%     
==========================================
  Files         909      915       +6     
  Lines       41175    41392     +217     
==========================================
+ Hits        21284    21437     +153     
- Misses      17869    17904      +35     
- Partials     2022     2051      +29     
Impacted Files Coverage Δ
pkg/test/xds/client/main.go 0.00% <0.00%> (ø)
pkg/xds/generator/direct_access_proxy_generator.go 80.26% <0.00%> (-1.32%) ⬇️
...k8s/native/controllers/proxytemplate_controller.go 0.00% <0.00%> (ø)
...kg/plugins/resources/k8s/native/pkg/test/within.go 100.00% <0.00%> (ø)
api/internal/util/proto/proto.go 62.50% <0.00%> (ø)
api/internal/util/proto/types.go 100.00% <0.00%> (ø)
pkg/test/xds/client/stream/client.go 0.00% <0.00%> (ø)
api/mesh/v1alpha1/dataplane_helpers.go 77.84% <0.00%> (+1.70%) ⬆️
api/mesh/v1alpha1/dataplane_insight_helpers.go 80.24% <0.00%> (+4.93%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc0cb70...9508897. Read the comment docs.

@jakubdyszkiewicz
Copy link
Contributor

Yeah, that should be V3. Merging this since the scope of this PR is to get rid of nested go module.

@jakubdyszkiewicz jakubdyszkiewicz merged commit a91e78b into kumahq:master Jul 5, 2021
mergify bot pushed a commit that referenced this pull request Jul 5, 2021
Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit a91e78b)
jakubdyszkiewicz pushed a commit that referenced this pull request Jul 5, 2021
Signed-off-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants