Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*) clean up ServiceIterator usage #2281

Merged
merged 1 commit into from
Jul 5, 2021
Merged

chore(*) clean up ServiceIterator usage #2281

merged 1 commit into from
Jul 5, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Jul 5, 2021

Summary

Return a ServiceIterator interface rather than a concrete
ServiceItoratorFunc, since the former is the abstraction
that matters.

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Return a ServiceIterator interface rather than a concrete
ServiceItoratorFunc, since the former is the abstraction
that matters.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach requested a review from a team as a code owner July 5, 2021 00:14
@codecov-commenter
Copy link

Codecov Report

Merging #2281 (51f7e26) into master (cc0cb70) will increase coverage by 0.33%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2281      +/-   ##
==========================================
+ Coverage   51.69%   52.02%   +0.33%     
==========================================
  Files         909      913       +4     
  Lines       41175    41208      +33     
==========================================
+ Hits        21284    21438     +154     
+ Misses      17869    17719     -150     
- Partials     2022     2051      +29     
Impacted Files Coverage Δ
pkg/core/policy/connection_matcher.go 95.87% <ø> (ø)
api/internal/util/proto/types.go 100.00% <0.00%> (ø)
api/internal/util/proto/proto.go 62.50% <0.00%> (ø)
...kg/plugins/resources/k8s/native/pkg/test/within.go 100.00% <0.00%> (ø)
...k8s/native/controllers/proxytemplate_controller.go 0.00% <0.00%> (ø)
api/mesh/v1alpha1/dataplane_helpers.go 77.84% <0.00%> (+1.70%) ⬆️
pkg/core/resources/manager/cache.go 83.09% <0.00%> (+2.81%) ⬆️
api/mesh/v1alpha1/dataplane_insight_helpers.go 80.24% <0.00%> (+4.93%) ⬆️
pkg/core/bootstrap/autoconfig.go 50.48% <0.00%> (+8.73%) ⬆️
api/observability/v1alpha1/mads.pb.go 23.91% <0.00%> (+9.42%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc0cb70...51f7e26. Read the comment docs.

@jpeach jpeach merged commit c0811ec into kumahq:master Jul 5, 2021
@jpeach jpeach deleted the chore/service-iterator-types branch July 5, 2021 06:29
mergify bot pushed a commit that referenced this pull request Jul 14, 2021
Return a ServiceIterator interface rather than a concrete
ServiceItoratorFunc, since the former is the abstraction
that matters.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit c0811ec)
bartsmykla pushed a commit that referenced this pull request Jul 14, 2021
Return a ServiceIterator interface rather than a concrete
ServiceItoratorFunc, since the former is the abstraction
that matters.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit c0811ec)

Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants