fix(kuma-cp) allocate a new VIP for ExternalService host #2302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
pkg/dns/outbound.go
Outdated
| externalServices []*core_mesh.ExternalServiceResource, | ||
| ) []*mesh_proto.Dataplane_Networking_Outbound { | ||
| type vipEntry struct { | ||
| ip string | ||
| port uint32 | ||
| host bool |
There was a problem hiding this comment.
how about EntryType?
| if err := json.Unmarshal([]byte(config), &v); err == nil { | ||
| return v, nil | ||
| } | ||
| backwardCompatible := map[string]string{} |
There was a problem hiding this comment.
drop the "canonical" backwards compatibility comment.
| @@ -109,6 +110,48 @@ networking: | |||
| Expect(stdout).ToNot(ContainSubstring("HTTPS")) | |||
| }) | |||
|
|
|||
| It("should route to external-service", func() { | |||
There was a problem hiding this comment.
there is already such It in this file. Can you add some comments on what is going on in this test?
// given two external services that point to the same hostname but different port
// when access first external service with .mesh
// then
/// when access first external service using hostname
// then
// when access second external service name using .mesh
// then
/// when access second external service using the same hostname as first but with different port
// then
something like that
Signed-off-by: lobkovilya <ilya.lobkov@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #2302 +/- ##
==========================================
+ Coverage 51.65% 51.94% +0.28%
==========================================
Files 910 914 +4
Lines 41098 41200 +102
==========================================
+ Hits 21229 21401 +172
+ Misses 17833 17733 -100
- Partials 2036 2066 +30
Continue to review full report at Codecov.
|
jakubdyszkiewicz
approved these changes
Jul 8, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jul 8, 2021
(cherry picked from commit 90b1c93)
bartsmykla
pushed a commit
that referenced
this pull request
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Kuma allocates VIP on every new service. Every ExternalService represents a single Kuma service. If we have 2 ExternalServices:
Then 2 VIPs will be allocated:
external-service-1: 240.0.0.1, external-service-2: 240.0.0.2.It will work fine while we consume services using
.meshdomain. But if we'd like to consume services usinghost.com. Built-in DNS feature will resolvehost.comeither to240.0.0.1or240.0.0.2, so one of the services won't work properly.Current PR introduces a new type of entry - host entry. Alongside service entries, Kuma will allocate
host.com: 240.0.0.3.Full changelog
Issues resolved
Fix #2176
Documentation
Testing