Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*) generate the remaining mesh resources #2311

Merged
merged 1 commit into from
Jul 13, 2021
Merged

chore(*) generate the remaining mesh resources #2311

merged 1 commit into from
Jul 13, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Jul 6, 2021

Summary

Generate the remaining mesh resource wrappers that were overlooked in
the previous pass.

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

@jpeach jpeach requested a review from a team as a code owner July 6, 2021 01:53
@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2021

Codecov Report

Merging #2311 (540f110) into master (3a950af) will increase coverage by 0.42%.
The diff coverage is 76.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2311      +/-   ##
==========================================
+ Coverage   52.13%   52.56%   +0.42%     
==========================================
  Files         875      876       +1     
  Lines       47801    47842      +41     
==========================================
+ Hits        24923    25147     +224     
+ Misses      20860    20647     -213     
- Partials     2018     2048      +30     
Impacted Files Coverage Δ
api/mesh/v1alpha1/dataplane.pb.go 36.33% <ø> (ø)
api/mesh/v1alpha1/health_check.pb.go 30.54% <ø> (ø)
api/mesh/v1alpha1/zone_ingress_insight.pb.go 54.83% <ø> (ø)
pkg/core/resources/apis/mesh/resources.go 80.97% <76.98%> (-0.63%) ⬇️
pkg/mads/v1/client/client.go 41.25% <0.00%> (-2.50%) ⬇️
api/observability/v1/mads.pb.go 34.53% <0.00%> (-1.04%) ⬇️
api/internal/util/proto/proto.go 70.00% <0.00%> (ø)
...k8s/native/controllers/proxytemplate_controller.go 0.00% <0.00%> (ø)
api/internal/util/proto/types.go 100.00% <0.00%> (ø)
...kg/plugins/resources/k8s/native/pkg/test/within.go 100.00% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a950af...540f110. Read the comment docs.

Generate the remaining mesh resource wrappers that were overlooked in
the previous pass.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach merged commit 1fb3081 into kumahq:master Jul 13, 2021
@jpeach jpeach deleted the chore/gen-mesh-resources branch July 13, 2021 21:34
mergify bot pushed a commit that referenced this pull request Jul 13, 2021
Generate the remaining mesh resource wrappers that were overlooked in
the previous pass.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 1fb3081)
jpeach added a commit that referenced this pull request Jul 13, 2021
Generate the remaining mesh resource wrappers that were overlooked in
the previous pass.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 1fb3081)

Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants