chore(kuma-cp) use resource types for DataplaneInsight tracking #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2324 +/- ##
==========================================
+ Coverage 50.50% 50.88% +0.37%
==========================================
Files 875 879 +4
Lines 40794 40844 +50
==========================================
+ Hits 20603 20782 +179
+ Misses 18201 18041 -160
- Partials 1990 2021 +31
Continue to review full report at Codecov.
|
When we track the Dataplane status, we could be using that to generate a DataplaneInsight or a ZoneIngressInsight. Previously, we used the presence of a mesh field to distinguish these cases, but we can take advantage of the fact that the xDS metadata round-trips the resource protobuf through the node metadata to determine the exact type when the we start tracking the xDS client stream. This has the additional property of not trying to create mis-matched insight resources for any other types of resources, which ultimately results in errors from the DataplaneInsightManager. Signed-off-by: James Peach <james.peach@konghq.com>
Signed-off-by: James Peach <james.peach@konghq.com>
lobkovilya
reviewed
Jul 8, 2021
Signed-off-by: James Peach <james.peach@konghq.com>
lobkovilya
approved these changes
Jul 9, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jul 12, 2021
When we track the Dataplane status, we could be using that to generate a DataplaneInsight or a ZoneIngressInsight. Previously, we used the presence of a mesh field to distinguish these cases, but we can take advantage of the fact that the xDS metadata round-trips the proxy type through the node metadata to determine the right resource type when the we start tracking the xDS client stream Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 82c6818)
jpeach
added a commit
that referenced
this pull request
Jul 12, 2021
… (#2349) When we track the Dataplane status, we could be using that to generate a DataplaneInsight or a ZoneIngressInsight. Previously, we used the presence of a mesh field to distinguish these cases, but we can take advantage of the fact that the xDS metadata round-trips the proxy type through the node metadata to determine the right resource type when the we start tracking the xDS client stream Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 82c6818) Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we track the Dataplane status, we could be using that to generate
a DataplaneInsight or a ZoneIngressInsight. Previously, we used the
presence of a mesh field to distinguish these cases, but we can take
advantage of the fact that the xDS metadata round-trips the resource
protobuf through the node metadata to determine the exact type when
the we start tracking the xDS client stream. This has the additional
property of not trying to create mis-matched insight resources for any
other types of resources, which ultimately results in errors from the
DataplaneInsightManager.
Full changelog
N/A
Issues resolved
N/A
Documentation
N/A
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.This ought to be backwards compatible (thanks integration tests!). We can handle node metadata from old bootstrap metadata as well as from the newly consistent metadata.