Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*) remove Go module for the changelog generator #2328

Merged
merged 1 commit into from
Jul 8, 2021
Merged

chore(*) remove Go module for the changelog generator #2328

merged 1 commit into from
Jul 8, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Jul 8, 2021

Summary

Remove the Go module for the changelog generator and hoist its
dependencies up into the root module. Fix all the new lint warnings,
since the linter wasn't running on the nested module.

Full changelog

N/A

Issues resolved

Updates #2200.

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Remove the Go module for the changelog generator and hoist its
dependencies up into the root module. Fix all the new lint warnings,
since the linter wasn't running on the nested module.

This updates #2200.

Signed-off-by: James Peach <james.peach@konghq.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2328 (1c159a7) into master (91e9477) will increase coverage by 0.23%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2328      +/-   ##
==========================================
+ Coverage   50.70%   50.93%   +0.23%     
==========================================
  Files         871      879       +8     
  Lines       40631    40761     +130     
==========================================
+ Hits        20601    20762     +161     
+ Misses      18034    17976      -58     
- Partials     1996     2023      +27     
Impacted Files Coverage Δ
tools/releases/changelog/generator.go 0.00% <0.00%> (ø)
tools/releases/changelog/main.go 0.00% <0.00%> (ø)
tools/releases/changelog/root.go 8.16% <0.00%> (ø)
tools/releases/changelog/utils.go 0.00% <ø> (ø)
pkg/xds/generator/direct_access_proxy_generator.go 80.26% <0.00%> (-1.32%) ⬇️
api/internal/util/proto/types.go 100.00% <0.00%> (ø)
...k8s/native/controllers/proxytemplate_controller.go 0.00% <0.00%> (ø)
...kg/plugins/resources/k8s/native/pkg/test/within.go 100.00% <0.00%> (ø)
api/internal/util/proto/proto.go 62.50% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91e9477...1c159a7. Read the comment docs.

@jpeach jpeach marked this pull request as ready for review July 8, 2021 06:58
@jpeach jpeach requested a review from a team as a code owner July 8, 2021 06:58
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jpeach jpeach merged commit 5db95ed into kumahq:master Jul 8, 2021
@jpeach jpeach deleted the chore/remove-changelog-mod branch July 8, 2021 23:44
mergify bot pushed a commit that referenced this pull request Jul 8, 2021
Remove the Go module for the changelog generator and hoist its
dependencies up into the root module. Fix all the new lint warnings,
since the linter wasn't running on the nested module.

This updates #2200.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 5db95ed)
jpeach added a commit that referenced this pull request Jul 9, 2021
Remove the Go module for the changelog generator and hoist its
dependencies up into the root module. Fix all the new lint warnings,
since the linter wasn't running on the nested module.

This updates #2200.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 5db95ed)

Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants