chore(kumactl) improve flags description, add extra validation #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lobkovilya <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <lobkovilya@yandex.ru>
Codecov Report
@@ Coverage Diff @@
## master #2352 +/- ##
==========================================
+ Coverage 52.14% 52.51% +0.37%
==========================================
Files 875 879 +4
Lines 47801 47841 +40
==========================================
+ Hits 24925 25125 +200
+ Misses 20855 20669 -186
- Partials 2021 2047 +26
Continue to review full report at Codecov.
|
jpeach
reviewed
Jul 14, 2021
| return errors.Errorf("--kuma-dp-user or --kuma-dp-uid should be supplied") | ||
| } | ||
|
|
||
| if args.RedirectAllDNSTraffic && args.RedirectDNS { | ||
| return errors.Errorf("one of --redirect-dns or --redirect-all-dns-traffic should be specified") |
There was a problem hiding this comment.
nit: I'd phrase this as
Suggested change
| return errors.Errorf("one of --redirect-dns or --redirect-all-dns-traffic should be specified") | |
| return errors.Errorf("exactly one of --redirect-dns or --redirect-all-dns-traffic should be specified") |
There was a problem hiding this comment.
None of them is also a valid case, I think I probably should do only one of ...?
jpeach
approved these changes
Jul 14, 2021
mergify bot
pushed a commit
that referenced
this pull request
Jul 14, 2021
(cherry picked from commit 4aa8ec3)
bartsmykla
pushed a commit
that referenced
this pull request
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some minor chores for
kumactl install transparent-proxycommand.Full changelog
--modify-iptables, correct me if I'm wrong but what's the point runningkumactl install transparent-proxywith--modify-iptables=false--redirect-dnsand--redirect-all-dns-trafficpassed at the same timeIssues resolved
Fix #XXX
Documentation
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.