Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*) simplify xDS route configurers #2361

Merged
merged 3 commits into from
Jul 17, 2021
Merged

chore(*) simplify xDS route configurers #2361

merged 3 commits into from
Jul 17, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Jul 14, 2021

Summary

Add Dynamic and Scoped (not implemented) route configurers to match
the static one. Refactor the higher level inbound and outbound route
configurers in terms of the static configurer.

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2021

Codecov Report

Merging #2361 (6b3537f) into master (84d04ca) will increase coverage by 0.43%.
The diff coverage is 95.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2361      +/-   ##
==========================================
+ Coverage   52.10%   52.53%   +0.43%     
==========================================
  Files         874      878       +4     
  Lines       47797    47848      +51     
==========================================
+ Hits        24903    25137     +234     
+ Misses      20870    20665     -205     
- Partials     2024     2046      +22     
Impacted Files Coverage Δ
...kg/xds/envoy/listeners/v3/http_route_configurer.go 92.00% <92.00%> (ø)
pkg/xds/envoy/listeners/configurers.go 96.40% <100.00%> (+0.13%) ⬆️
...voy/listeners/v3/http_inbound_routes_configurer.go 100.00% <100.00%> (+12.50%) ⬆️
...voy/listeners/v3/http_outbound_route_configurer.go 100.00% <100.00%> (+13.33%) ⬆️
pkg/kds/client/sink.go 47.72% <0.00%> (-4.55%) ⬇️
pkg/core/runtime/component/component.go 81.13% <0.00%> (-3.78%) ⬇️
pkg/dns/vips_allocator.go 74.19% <0.00%> (-1.62%) ⬇️
...kg/plugins/resources/k8s/native/pkg/test/within.go 100.00% <0.00%> (ø)
api/internal/util/proto/proto.go 70.00% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84d04ca...6b3537f. Read the comment docs.

@jpeach jpeach marked this pull request as ready for review July 14, 2021 06:35
@jpeach jpeach requested a review from a team as a code owner July 14, 2021 06:35
Add Dynamic and Scoped (not implemented) route configurers to match
the static one. Refactor the higher level inbound and outbound route
configurers in terms of the static configurer.

Signed-off-by: James Peach <james.peach@konghq.com>
Signed-off-by: James Peach <james.peach@konghq.com>
Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach merged commit a7c748b into kumahq:master Jul 17, 2021
mergify bot pushed a commit that referenced this pull request Jul 17, 2021
(cherry picked from commit a7c748b)

# Conflicts:
#	pkg/xds/envoy/listeners/configurers.go
jpeach added a commit that referenced this pull request Jul 18, 2021
jpeach added a commit that referenced this pull request Jul 18, 2021
Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit a7c748b)
jpeach added a commit that referenced this pull request Jul 18, 2021
Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit a7c748b)

Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants