-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(*) simplify xDS route configurers #2361
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2361 +/- ##
==========================================
+ Coverage 52.10% 52.53% +0.43%
==========================================
Files 874 878 +4
Lines 47797 47848 +51
==========================================
+ Hits 24903 25137 +234
+ Misses 20870 20665 -205
- Partials 2024 2046 +22
Continue to review full report at Codecov.
|
lobkovilya
reviewed
Jul 14, 2021
lobkovilya
approved these changes
Jul 16, 2021
Add Dynamic and Scoped (not implemented) route configurers to match the static one. Refactor the higher level inbound and outbound route configurers in terms of the static configurer. Signed-off-by: James Peach <james.peach@konghq.com>
Signed-off-by: James Peach <james.peach@konghq.com>
Signed-off-by: James Peach <james.peach@konghq.com>
mergify bot
pushed a commit
that referenced
this pull request
Jul 17, 2021
(cherry picked from commit a7c748b) # Conflicts: # pkg/xds/envoy/listeners/configurers.go
jpeach
added a commit
that referenced
this pull request
Jul 18, 2021
(cherry picked from commit a7c748b)
jpeach
added a commit
that referenced
this pull request
Jul 18, 2021
Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit a7c748b)
jpeach
added a commit
that referenced
this pull request
Jul 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Dynamic and Scoped (not implemented) route configurers to match
the static one. Refactor the higher level inbound and outbound route
configurers in terms of the static configurer.
Full changelog
N/A
Issues resolved
N/A
Documentation
N/A
Testing
Backwards compatibility
backport-to-stable
label if the code is backwards compatible. Otherwise, list breaking changes.