Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*) use the typed config for TLS Inspector #2373

Merged
merged 1 commit into from
Jul 17, 2021
Merged

fix(*) use the typed config for TLS Inspector #2373

merged 1 commit into from
Jul 17, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Jul 15, 2021

Summary

The TLS Inspector has its own typed config protobuf that we should use
for the filter rather than an empty protobuf.

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

The TLS Inspector has its own typed config protobuf that we should use
for the filter rather than an empty protobuf.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach marked this pull request as ready for review July 15, 2021 04:59
@jpeach jpeach requested a review from a team as a code owner July 15, 2021 04:59
@codecov-commenter
Copy link

Codecov Report

Merging #2373 (ccbdf14) into master (b0c72d1) will increase coverage by 0.41%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2373      +/-   ##
==========================================
+ Coverage   52.13%   52.54%   +0.41%     
==========================================
  Files         874      878       +4     
  Lines       47826    47867      +41     
==========================================
+ Hits        24936    25154     +218     
+ Misses      20865    20662     -203     
- Partials     2025     2051      +26     
Impacted Files Coverage Δ
...xds/envoy/listeners/v3/tls_inspector_configurer.go 81.81% <100.00%> (ø)
api/internal/util/proto/types.go 100.00% <0.00%> (ø)
api/internal/util/proto/proto.go 70.00% <0.00%> (ø)
...kg/plugins/resources/k8s/native/pkg/test/within.go 100.00% <0.00%> (ø)
...k8s/native/controllers/proxytemplate_controller.go 0.00% <0.00%> (ø)
pkg/xds/generator/direct_access_proxy_generator.go 83.90% <0.00%> (+1.14%) ⬆️
api/mesh/v1alpha1/dataplane_helpers.go 80.16% <0.00%> (+1.68%) ⬆️
pkg/plugins/resources/memory/store.go 82.06% <0.00%> (+4.34%) ⬆️
api/mesh/v1alpha1/dataplane_insight_helpers.go 83.33% <0.00%> (+5.20%) ⬆️
pkg/xds/cache/once/cache.go 94.87% <0.00%> (+7.69%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c72d1...ccbdf14. Read the comment docs.

@jpeach jpeach merged commit b3c1f81 into kumahq:master Jul 17, 2021
@jpeach jpeach deleted the fix/tls-inspector-type branch July 17, 2021 01:06
mergify bot pushed a commit that referenced this pull request Jul 17, 2021
The TLS Inspector has its own typed config protobuf that we should use
for the filter rather than an empty protobuf.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit b3c1f81)
jpeach added a commit that referenced this pull request Jul 18, 2021
The TLS Inspector has its own typed config protobuf that we should use
for the filter rather than an empty protobuf.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit b3c1f81)

Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants