chore(*) remove the GatewayProxyType constant #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GatewayProxyType constant is not actually used anywhere, and creates some confusion with a dataplane operating in gateway mode. Delete it to remove any ambiguity. Signed-off-by: James Peach <james.peach@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #2392 +/- ##
==========================================
+ Coverage 52.35% 52.53% +0.18%
==========================================
Files 875 877 +2
Lines 47816 47838 +22
==========================================
+ Hits 25033 25133 +100
+ Misses 20747 20657 -90
- Partials 2036 2048 +12
Continue to review full report at Codecov.
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 20, 2021
The GatewayProxyType constant is not actually used anywhere, and creates some confusion with a dataplane operating in gateway mode. Delete it to remove any ambiguity. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit fc3614d) # Conflicts: # pkg/config/app/kuma-dp/config_test.go
jpeach
added a commit
that referenced
this pull request
Jul 21, 2021
The GatewayProxyType constant is not actually used anywhere, and creates some confusion with a dataplane operating in gateway mode. Delete it to remove any ambiguity. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit fc3614d)
jpeach
added a commit
that referenced
this pull request
Jul 22, 2021
The GatewayProxyType constant is not actually used anywhere, and creates some confusion with a dataplane operating in gateway mode. Delete it to remove any ambiguity. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit fc3614d) Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The GatewayProxyType constant is not actually used anywhere, and creates
some confusion with a dataplane operating in gateway mode. Delete it to
remove any ambiguity.
Full changelog
N/A
Issues resolved
N/A
Documentation
N/A
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.