Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*) update remaining listener filter helpers #2393

Merged
merged 1 commit into from
Jul 20, 2021
Merged

chore(*) update remaining listener filter helpers #2393

merged 1 commit into from
Jul 20, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Jul 18, 2021

Summary

Update the remaining listener configurer helpers. These were omitted from
previous PRs due to merge conflicts.

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Update the remaining listener configurer helpers. These were omitted
from previous PRs due to merge conflicts.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach requested a review from a team as a code owner July 18, 2021 22:59
@codecov-commenter
Copy link

Codecov Report

Merging #2393 (caa89ec) into master (a7c748b) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2393      +/-   ##
==========================================
+ Coverage   52.35%   52.54%   +0.19%     
==========================================
  Files         875      877       +2     
  Lines       47816    47836      +20     
==========================================
+ Hits        25033    25137     +104     
+ Misses      20747    20654      -93     
- Partials     2036     2045       +9     
Impacted Files Coverage Δ
pkg/xds/envoy/listeners/configurers.go 96.36% <100.00%> (-0.05%) ⬇️
api/internal/util/proto/proto.go 70.00% <0.00%> (ø)
api/internal/util/proto/types.go 100.00% <0.00%> (ø)
api/mesh/v1alpha1/dataplane_helpers.go 80.16% <0.00%> (+1.68%) ⬆️
pkg/plugins/resources/memory/store.go 82.06% <0.00%> (+4.34%) ⬆️
api/mesh/v1alpha1/dataplane_insight_helpers.go 83.33% <0.00%> (+5.20%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️
api/observability/v1alpha1/mads.pb.go 21.26% <0.00%> (+8.62%) ⬆️
pkg/core/resources/store/customizable_store.go 88.88% <0.00%> (+11.11%) ⬆️
api/system/v1alpha1/zone_insight_helpers.go 72.22% <0.00%> (+25.92%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c748b...caa89ec. Read the comment docs.

@jpeach jpeach merged commit 6ccc61a into kumahq:master Jul 20, 2021
mergify bot pushed a commit that referenced this pull request Jul 20, 2021
Update the remaining listener configurer helpers. These were omitted
from previous PRs due to merge conflicts.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 6ccc61a)
@jpeach jpeach deleted the chore/update-listen-filters branch July 20, 2021 21:35
jpeach added a commit that referenced this pull request Jul 22, 2021
Update the remaining listener configurer helpers. These were omitted
from previous PRs due to merge conflicts.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 6ccc61a)

Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants