Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kuma-cp) upgrade gui to new version #2395

Merged

Conversation

tomaszwylezek
Copy link
Contributor

Signed-off-by: Tomasz Wylężek tomwylezek@gmail.com

Summary

PR: kumahq/kuma-gui#179

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #2395 (7aa5367) into master (a7c748b) will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2395      +/-   ##
==========================================
+ Coverage   52.35%   52.54%   +0.19%     
==========================================
  Files         875      877       +2     
  Lines       47816    47838      +22     
==========================================
+ Hits        25033    25138     +105     
+ Misses      20747    20654      -93     
- Partials     2036     2046      +10     
Impacted Files Coverage Δ
pkg/mads/v1/client/client.go 41.25% <0.00%> (-2.50%) ⬇️
api/observability/v1/mads.pb.go 34.53% <0.00%> (-1.04%) ⬇️
pkg/core/resources/manager/cache.go 81.81% <0.00%> (ø)
api/internal/util/proto/proto.go 70.00% <0.00%> (ø)
api/internal/util/proto/types.go 100.00% <0.00%> (ø)
api/mesh/v1alpha1/dataplane_helpers.go 80.16% <0.00%> (+1.68%) ⬆️
pkg/plugins/resources/memory/store.go 82.06% <0.00%> (+4.34%) ⬆️
api/mesh/v1alpha1/dataplane_insight_helpers.go 83.33% <0.00%> (+5.20%) ⬆️
pkg/xds/cache/once/cache.go 94.87% <0.00%> (+7.69%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7c748b...7aa5367. Read the comment docs.

@tomaszwylezek tomaszwylezek merged commit 449f6fe into kumahq:master Jul 19, 2021
@tomaszwylezek tomaszwylezek deleted the chore/upgrade-gui-version branch July 19, 2021 09:36
mergify bot pushed a commit that referenced this pull request Jul 19, 2021
Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
(cherry picked from commit 449f6fe)
tomaszwylezek added a commit that referenced this pull request Jul 19, 2021
Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
(cherry picked from commit 449f6fe)

Co-authored-by: Tomasz Wylężek <tomwylezek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants