Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(kuma-cp) upgrade gui to new version #2408

Merged
merged 1 commit into from
Jul 22, 2021
Merged

chore(kuma-cp) upgrade gui to new version #2408

merged 1 commit into from
Jul 22, 2021

Conversation

tomaszwylezek
Copy link
Contributor

Signed-off-by: Tomasz Wylężek tomwylezek@gmail.com

Summary

PR: kumahq/kuma-gui#181

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

@tomaszwylezek
chore(kuma-cp) upgrade gui to new version
3b92802 
Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
@tomaszwylezek tomaszwylezek requested a review from a team as a code owner July 21, 2021 14:42
bartsmykla
bartsmykla approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #2408 (3b92802) into master (f4c852d) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2408      +/-   ##
==========================================
+ Coverage   52.32%   52.53%   +0.21%     
==========================================
  Files         876      878       +2     
  Lines       47837    47859      +22     
==========================================
+ Hits        25032    25145     +113     
+ Misses      20772    20666     -106     
- Partials     2033     2048      +15
Impacted Files Coverage Δ
api/internal/util/proto/types.go 100.00% <0.00%> (ø)
api/internal/util/proto/proto.go 70.00% <0.00%> (ø)
api/observability/v1/mads.pb.go 35.56% <0.00%> (+1.03%) ⬆️
pkg/xds/generator/direct_access_proxy_generator.go 83.90% <0.00%> (+1.14%) ⬆️
api/mesh/v1alpha1/dataplane_helpers.go 79.32% <0.00%> (+1.68%) ⬆️
pkg/mads/v1/client/client.go 43.75% <0.00%> (+2.50%) ⬆️
pkg/insights/resyncer.go 66.38% <0.00%> (+2.94%) ⬆️
api/mesh/v1alpha1/dataplane_insight_helpers.go 83.33% <0.00%> (+5.20%) ⬆️
pkg/events/eventbus.go 92.59% <0.00%> (+7.40%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4c852d...3b92802. Read the comment docs.

@tomaszwylezek tomaszwylezek merged commit f3ca1c7 into kumahq:master Jul 22, 2021
@tomaszwylezek tomaszwylezek deleted the chore/upgrade-gui branch July 22, 2021 07:09
mergify bot pushed a commit that referenced this pull request Jul 22, 2021
@tomaszwylezek
chore(kuma-cp) upgrade gui to new version (#2408)
dffc76c 
Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
(cherry picked from commit f3ca1c7)
@mergify mergify bot mentioned this pull request Jul 22, 2021
Merged
tomaszwylezek added a commit that referenced this pull request Jul 22, 2021
@mergify @tomaszwylezek
chore(kuma-cp) upgrade gui to new version (#2408) (#2416)
8961196 
Signed-off-by: Tomasz Wylężek <tomwylezek@gmail.com>
(cherry picked from commit f3ca1c7)

Co-authored-by: Tomasz Wylężek <tomwylezek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartsmykla bartsmykla bartsmykla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomaszwylezek @codecov-commenter @bartsmykla