feat(kuma-cp) add Gateway resource type #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Arguably, this proto definition should be in the gateway plugin (see #2412). Happy to move it there if that's the consensus. |
Codecov Report
@@ Coverage Diff @@
## master #2428 +/- ##
==========================================
- Coverage 52.61% 52.59% -0.02%
==========================================
Files 885 887 +2
Lines 47971 48394 +423
==========================================
+ Hits 25238 25453 +215
- Misses 20689 20891 +202
- Partials 2044 2050 +6
Continue to review full report at Codecov.
|
jpeach
commented
Jul 27, 2021
jpeach
commented
Jul 27, 2021
jpeach
commented
Jul 27, 2021
lobkovilya
reviewed
Jul 28, 2021
|
Back to draft while I add validation and tests. |
Signed-off-by: James Peach <james.peach@konghq.com>
Signed-off-by: James Peach <james.peach@konghq.com>
lobkovilya
reviewed
Jul 30, 2021
Signed-off-by: James Peach <james.peach@konghq.com>
Signed-off-by: James Peach <james.peach@konghq.com>
lobkovilya
approved these changes
Jul 30, 2021
Signed-off-by: James Peach <james.peach@konghq.com>
mergify bot
pushed a commit
that referenced
this pull request
Jul 30, 2021
Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 4d7e7c0) # Conflicts: # pkg/core/resources/apis/mesh/validators.go
jpeach
added a commit
that referenced
this pull request
Jul 31, 2021
Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 4d7e7c0)
jpeach
added a commit
that referenced
this pull request
Aug 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a Gateway resource. This just defines the type, which is not registered or used in any way. When enough PRs land, the type will be registered from the gateway plugin, which will be enabled by a build tag for a good long while yet.
Full changelog
N/A
Issues resolved
N/A
Documentation
N/A
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.