Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*) make port validation consistent #2448

Merged
merged 2 commits into from
Jul 30, 2021
Merged

chore(*) make port validation consistent #2448

merged 2 commits into from
Jul 30, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Jul 29, 2021

Summary

Introduce a helper to make TCP/UDP port validation checks
consistent across the API.

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

@jpeach jpeach requested a review from a team as a code owner July 29, 2021 05:03
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2021

Codecov Report

Merging #2448 (bda1cad) into master (9e8e2b7) will increase coverage by 0.09%.
The diff coverage is 95.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2448      +/-   ##
==========================================
+ Coverage   52.52%   52.62%   +0.09%     
==========================================
  Files         879      879              
  Lines       47923    47918       -5     
==========================================
+ Hits        25170    25215      +45     
+ Misses      20710    20651      -59     
- Partials     2043     2052       +9     
Impacted Files Coverage Δ
pkg/core/resources/apis/mesh/mesh_validator.go 85.00% <0.00%> (+0.60%) ⬆️
...kg/core/resources/apis/mesh/dataplane_validator.go 93.78% <100.00%> (+0.92%) ⬆️
...e/resources/apis/mesh/externalservice_validator.go 100.00% <100.00%> (ø)
pkg/core/resources/apis/mesh/validators.go 90.82% <100.00%> (+0.44%) ⬆️
...core/resources/apis/mesh/zone_ingress_validator.go 85.18% <100.00%> (+5.18%) ⬆️
pkg/mads/v1/client/client.go 41.25% <0.00%> (-2.50%) ⬇️
api/observability/v1/mads.pb.go 34.53% <0.00%> (-1.04%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 83.90% <0.00%> (+1.14%) ⬆️
pkg/core/resources/model/rest/resource.go 69.23% <0.00%> (+1.28%) ⬆️
api/mesh/v1alpha1/dataplane.pb.go 37.85% <0.00%> (+2.01%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e8e2b7...bda1cad. Read the comment docs.

@lobkovilya
Copy link
Contributor

Looks good! Please add the same for externalservice_validator.go

Introduce a helper to make TCP/UDP port validation checks
consistent across the API.

Signed-off-by: James Peach <james.peach@konghq.com>
Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach merged commit bb07923 into kumahq:master Jul 30, 2021
@jpeach jpeach deleted the chore/net-port-validation branch July 30, 2021 07:47
mergify bot pushed a commit that referenced this pull request Jul 30, 2021
Introduce a helper to make TCP/UDP port validation checks
consistent across the API.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit bb07923)
jpeach added a commit that referenced this pull request Jul 31, 2021
Introduce a helper to make TCP/UDP port validation checks
consistent across the API.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit bb07923)

Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants