fix(kuma-cp) add owner when create ZoneIngressInsight #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <lobkovilya@yandex.ru>
jpeach
approved these changes
Jul 30, 2021
| @@ -23,7 +23,8 @@ type zoneManager struct { | |||
| } | |||
|
|
|||
| func (z *zoneManager) Delete(ctx context.Context, r model.Resource, opts ...core_store.DeleteOptionsFunc) error { | |||
| if err := z.validator.ValidateDelete(ctx, r.GetMeta().GetName()); err != nil { | |||
| options := core_store.NewDeleteOptions(opts...) | |||
| if err := z.validator.ValidateDelete(ctx, options.Name); err != nil { | |||
There was a problem hiding this comment.
Nit: seems like it would be cleaner to pass the delete options down to VallidateDelete. If you agree, file a follow up issue?
pkg/core/managers/apis/zoneingressinsight/zone_ingress_insight_manager.go
Show resolved
Hide resolved
pkg/core/managers/apis/zoneingressinsight/zone_ingress_insight_manager_test.go
Show resolved
Hide resolved
pkg/core/managers/apis/zoneingressinsight/zone_ingress_insight_manager.go
Outdated
Show resolved
Hide resolved
| Expect(actual.Spec.Subscriptions[2].Id).To(Equal("9")) | ||
| }) | ||
|
|
||
| It("should cleanup subscriptions if disabled", func() { |
There was a problem hiding this comment.
What if the store already has some insights in it, then you restart the manager with metrics disabled. Should they be deleted? Is it worth making a separate test for that?
There was a problem hiding this comment.
No, they will be deleted only when Create/Update method will be called. So I'm not sure if this has to be tested
Co-authored-by: James Peach <james.peach@konghq.com>
Signed-off-by: Ilya Lobkov <lobkovilya@yandex.ru>
Signed-off-by: Ilya Lobkov <lobkovilya@yandex.ru> # Conflicts: # pkg/api-server/definitions/all.go
Signed-off-by: Ilya Lobkov <lobkovilya@yandex.ru>
lobkovilya
force-pushed
the
fix/zone-ingress-insight-owner
branch
from
97f0c67
to
0cfa450
Compare
Codecov Report
@@ Coverage Diff @@
## master #2456 +/- ##
==========================================
- Coverage 52.37% 52.36% -0.01%
==========================================
Files 866 868 +2
Lines 48249 48332 +83
==========================================
+ Hits 25270 25311 +41
- Misses 20939 20980 +41
- Partials 2040 2041 +1
Continue to review full report at Codecov.
|
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> # Conflicts: # pkg/core/bootstrap/bootstrap.go
mergify bot
pushed a commit
that referenced
this pull request
Aug 5, 2021
(cherry picked from commit cc10d19) # Conflicts: # app/kuma-dp/cmd/run.go # pkg/core/bootstrap/bootstrap.go
jpeach
pushed a commit
that referenced
this pull request
Aug 11, 2021
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> (cherry picked from commit cc10d19)
jpeach
pushed a commit
that referenced
this pull request
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were missing ZoneIngressInsight manager that sets ownership when creating resources.
Full changelog
kumactl delete zone <zone-nameIssues resolved
N/A
Documentation
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.