chore(tools): improve resource-gen by auto generating ws code #2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahabana
force-pushed
the
chore/generate_definitions
branch
2 times, most recently
from
2887ac3
to
3558ec0
Compare
This code was systematically created. We generate code to make this code auto generated from protobuf annotations This adds boilerplate code for the validator and tests if they don't exist already. The goal is to make creating a new policy less cumbersome. Signed-off-by: Charly Molter <charly.molter@konghq.com>
lahabana
force-pushed
the
chore/generate_definitions
branch
from
3558ec0
to
e9b2be4
Compare
jpeach
reviewed
Aug 2, 2021
1 task
…efinitions Signed-off-by: Charly Molter <charly.molter@konghq.com>
Signed-off-by: Charly Molter <charly.molter@konghq.com>
lahabana
force-pushed
the
chore/generate_definitions
branch
from
1fbc63e
to
4252444
Compare
|
@jpeach I added what you were suggesting. It almost feels that instead of having 2 extensions there should be one with different options. |
Codecov Report
@@ Coverage Diff @@
## master #2466 +/- ##
==========================================
- Coverage 52.47% 52.43% -0.05%
==========================================
Files 868 866 -2
Lines 48198 48249 +51
==========================================
+ Hits 25294 25299 +5
- Misses 20868 20912 +44
- Partials 2036 2038 +2
Continue to review full report at Codecov.
|
jpeach
approved these changes
Aug 3, 2021
What did you have in mind? |
…efinitions Signed-off-by: Charly Molter <charly.molter@konghq.com>
|
Instead of having: Have: It seems a little simpler than have a lot of options. |
mergify bot
pushed a commit
that referenced
this pull request
Aug 3, 2021
This code was systematically created. We generate code for webservices to make this code auto generated from protobuf annotations The goal is to make creating a new policy less cumbersome. Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit ac839aa) # Conflicts: # pkg/api-server/definitions/all.go # pkg/api-server/definitions/api.go # pkg/api-server/definitions/circuit_breaker.go # pkg/api-server/definitions/dataplane.go # pkg/api-server/definitions/dataplane_insight.go # pkg/api-server/definitions/definition.go # pkg/api-server/definitions/external_service.go # pkg/api-server/definitions/fault_injection.go # pkg/api-server/definitions/global_secret.go # pkg/api-server/definitions/health_check.go # pkg/api-server/definitions/mesh.go # pkg/api-server/definitions/mesh_insight.go # pkg/api-server/definitions/proxytemplate.go # pkg/api-server/definitions/rate_limit.go # pkg/api-server/definitions/retry.go # pkg/api-server/definitions/secret.go # pkg/api-server/definitions/service_insight.go # pkg/api-server/definitions/timeout.go # pkg/api-server/definitions/traffic_log.go # pkg/api-server/definitions/traffic_permission.go # pkg/api-server/definitions/traffic_route.go # pkg/api-server/definitions/traffic_trace.go # pkg/api-server/definitions/zone-ingress.go # pkg/api-server/definitions/zone.go # pkg/api-server/definitions/zone_insight.go # pkg/api-server/server.go
lahabana
added a commit
that referenced
this pull request
Aug 4, 2021
This code was systematically created. We generate code for webservices to make this code auto generated from protobuf annotations The goal is to make creating a new policy less cumbersome. Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit ac839aa)
lahabana
pushed a commit
that referenced
this pull request
Aug 4, 2021
…#2485) This code was systematically created. We generate code for webservices to make this code auto generated from protobuf annotations The goal is to make creating a new policy less cumbersome. Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit ac839aa) Co-authored-by: Charly Molter <charly.molter@konhq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was systematically created.
We generate code to make this code auto generated from protobuf annotations. It avoids users adding this code manually and ensure it's coherent.
Signed-off-by: Charly Molter charly.molter@konghq.com