feat(*) register the gateway resource type #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Likely to be refactored by #2469 |
jakubdyszkiewicz
approved these changes
Aug 2, 2021
|
Rebased. Looking at test failures. |
When the build flag is enabled, register the Gateway resource in the kuma-cp and in kumactl. The latter adds a simple hook to let the plugin modify the kumactl commands. This is likely to be refactored away as more of the type bindings are generated. Signed-off-by: James Peach <james.peach@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #2474 +/- ##
==========================================
+ Coverage 52.46% 52.50% +0.04%
==========================================
Files 865 868 +3
Lines 48150 48198 +48
==========================================
+ Hits 25260 25306 +46
+ Misses 20855 20852 -3
- Partials 2035 2040 +5
Continue to review full report at Codecov.
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 11, 2021
When the build flag is enabled, register the Gateway resource in the kuma-cp and in kumactl. The latter adds a simple hook to let the plugin modify the kumactl commands. This is likely to be refactored away as more of the type bindings are generated. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit b8db547) # Conflicts: # pkg/plugins/runtime/gateway/enabled.go # pkg/plugins/runtime/gateway/kumactl/plugin.go
jpeach
added a commit
that referenced
this pull request
Aug 11, 2021
When the build flag is enabled, register the Gateway resource in the kuma-cp and in kumactl. The latter adds a simple hook to let the plugin modify the kumactl commands. This is likely to be refactored away as more of the type bindings are generated. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit b8db547)
jpeach
added a commit
that referenced
this pull request
Aug 12, 2021
When the build flag is enabled, register the Gateway resource in the kuma-cp and in kumactl. The latter adds a simple hook to let the plugin modify the kumactl commands. This is likely to be refactored away as more of the type bindings are generated. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit b8db547) Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the build flag is enabled, register the Gateway resource in the
kuma-cp and in kumactl. The latter adds a simple hook to let the plugin
modify the kumactl commands. This is likely to be refactored away as
more of the type bindings are generated.
Full changelog
N/A
Issues resolved
N/A
Documentation
N/A
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.