add importas to golangci-lint #2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tharun <rajendrantharun@live.com>
Signed-off-by: Tharun <rajendrantharun@live.com>
tharun208
changed the title
jpeach
approved these changes
Aug 8, 2021
Codecov Report
@@ Coverage Diff @@
## master #2516 +/- ##
==========================================
+ Coverage 52.14% 52.19% +0.05%
==========================================
Files 866 866
Lines 48307 48307
==========================================
+ Hits 25191 25216 +25
+ Misses 21080 21046 -34
- Partials 2036 2045 +9
Continue to review full report at Codecov.
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 9, 2021
- add importas rule - fix import names Signed-off-by: Tharun <rajendrantharun@live.com> (cherry picked from commit 2e3ace0) # Conflicts: # .golangci.yml # app/kumactl/cmd/delete/delete_test.go # app/kumactl/pkg/output/json/json_test.go # app/kumactl/pkg/output/yaml/yaml_test.go # pkg/defaults/components_test.go # pkg/dns/vips/persistence.go # pkg/dns/vips/persistence_test.go # pkg/mads/v1/generator/assignments_test.go # pkg/mads/v1/reconcile/snapshot_generator_test.go # pkg/mads/v1alpha1/generator/assignments_test.go # pkg/mads/v1alpha1/reconcile/snapshot_generator_test.go # pkg/plugins/resources/k8s/native/api/v1alpha1/zone_ingress_types_helpers.go # pkg/plugins/runtime/k8s/webhooks/injector/injector.go # pkg/plugins/runtime/k8s/webhooks/mesh_validator.go # pkg/sds/server/v3/reconciler.go # pkg/xds/envoy/clusters/v3/client_side_tls_configurer_test.go # pkg/xds/envoy/clusters/v3/dns_cluster_configurer_test.go # pkg/xds/envoy/clusters/v3/eds_cluster_configurer_test.go # pkg/xds/envoy/clusters/v3/health_check_configurer.go # pkg/xds/envoy/clusters/v3/pass_through_cluster_configurer_test.go # pkg/xds/envoy/clusters/v3/static_cluster_configurer_test.go # pkg/xds/envoy/clusters/v3/strict_dns_cluster_configurer_test.go # pkg/xds/envoy/listeners/v3/max_connect_attempts_configurer_test.go # pkg/xds/envoy/listeners/v3/network_rbac_configurer_test.go # pkg/xds/envoy/listeners/v3/retry_configurer_test.go # pkg/xds/generator/inbound_proxy_generator.go # pkg/xds/generator/outbound_proxy_generator.go # pkg/xds/generator/prometheus_endpoint_generator_test.go # pkg/xds/generator/protocol_test.go # pkg/xds/generator/tracing_generator_test.go # pkg/xds/sync/dataplane_watchdog.go # pkg/xds/topology/outbound_test.go
jpeach
pushed a commit
that referenced
this pull request
Aug 11, 2021
- add importas rule - fix import names Signed-off-by: Tharun <rajendrantharun@live.com> (cherry picked from commit 2e3ace0)
jpeach
pushed a commit
that referenced
this pull request
Aug 11, 2021
- add importas rule - fix import names Signed-off-by: Tharun Rajendran <rajendrantharun@live.com> (cherry picked from commit 2e3ace0)
jpeach
pushed a commit
that referenced
this pull request
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY_GOES_HERE
Full changelog
importasrule to golangci-lintIssues resolved
Fix #2459
Documentation
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.