Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(*) fix kumactl generate dataplane proxy-type flag in deprecated… #2522

Merged
merged 1 commit into from
Aug 9, 2021
Merged

chore(*) fix kumactl generate dataplane proxy-type flag in deprecated… #2522

merged 1 commit into from
Aug 9, 2021

Conversation

tharun208
Copy link
Contributor

… message

Signed-off-by: Tharun rajendrantharun@live.com

Summary

SUMMARY_GOES_HERE

Full changelog

  • [Implement ...]
  • fix wrong generate data-plane command's proxy-type field name in deprecated message.

Issues resolved

Fix #2513

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

@tharun208
chore(*) fix kumactl generate dataplane proxy-type flag in deprecated…
d471c30 
… message

Signed-off-by: Tharun <rajendrantharun@live.com>
@tharun208 tharun208 requested a review from a team as a code owner August 9, 2021 07:58
lahabana
lahabana approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jpeach jpeach merged commit 0b188a4 into kumahq:master Aug 9, 2021
mergify bot pushed a commit that referenced this pull request Aug 9, 2021
@tharun208
chore(*) fix kumactl generate dataplane proxy-type flag deprecation m…
41054f8 
…essage (#2522)

Signed-off-by: Tharun <rajendrantharun@live.com>
(cherry picked from commit 0b188a4)
@mergify mergify bot mentioned this pull request Aug 9, 2021
Merged
@tharun208 tharun208 deleted the fix/kumactl_generate_token_flag branch August 10, 2021 03:52
jpeach pushed a commit that referenced this pull request Aug 12, 2021
@tharun208 @jpeach
chore(*) fix kumactl generate dataplane proxy-type flag deprecation m…
d67ee57 
…essage (#2522)

Signed-off-by: Tharun Rajendran <rajendrantharun@live.com>
(cherry picked from commit 0b188a4)
jpeach pushed a commit that referenced this pull request Aug 12, 2021
@mergify @tharun208
chore(*) fix kumactl generate dataplane proxy-type flag deprecation m…
20ac676 
…essage (#2522) (#2535)

Signed-off-by: Tharun Rajendran <rajendrantharun@live.com>
(cherry picked from commit 0b188a4)

Co-authored-by: Tharun Rajendran <rajendrantharun@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahabana lahabana lahabana approved these changes

@jakubdyszkiewicz jakubdyszkiewicz jakubdyszkiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Errors in kumactl message regarding type parameter for token generation
4 participants
@tharun208 @lahabana @jakubdyszkiewicz @jpeach