Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*) prepare kuma-[cd]p for windows compilation #2559

Merged

Conversation

bartsmykla
Copy link
Contributor

Summary

With this changes kuma-cp and kuma-dp can be compiled on and for windows

Issues resolved

no issue resolved, but I think these one are related:

Documentation

no documentation changes

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2559 (eb86293) into master (210fdb0) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2559      +/-   ##
==========================================
+ Coverage   52.38%   52.43%   +0.05%     
==========================================
  Files         871      871              
  Lines       48437    48437              
==========================================
+ Hits        25373    25399      +26     
+ Misses      21009    20985      -24     
+ Partials     2055     2053       -2     
Impacted Files Coverage Δ
pkg/util/os/limits.go 68.42% <ø> (ø)
pkg/core/resources/model/rest/resource.go 67.94% <0.00%> (-1.29%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 82.75% <0.00%> (-1.15%) ⬇️
pkg/core/resources/manager/cache.go 81.81% <0.00%> (ø)
api/observability/v1/mads.pb.go 35.56% <0.00%> (+1.03%) ⬆️
pkg/mads/v1/client/client.go 43.75% <0.00%> (+2.50%) ⬆️
app/kumactl/cmd/root.go 73.68% <0.00%> (+3.50%) ⬆️
pkg/plugins/resources/memory/store.go 82.06% <0.00%> (+4.34%) ⬆️
pkg/xds/cache/once/cache.go 94.87% <0.00%> (+7.69%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 210fdb0...eb86293. Read the comment docs.

@bartsmykla bartsmykla merged commit d34dddc into kumahq:master Aug 13, 2021
@bartsmykla bartsmykla deleted the feat/prepare-for-windows-compilation branch August 13, 2021 07:29
mergify bot pushed a commit that referenced this pull request Aug 13, 2021
Signed-off-by: Bart Smykla <bartek@smykla.com>
(cherry picked from commit d34dddc)
bartsmykla added a commit that referenced this pull request Aug 13, 2021
Signed-off-by: Bart Smykla <bartek@smykla.com>
(cherry picked from commit d34dddc)

Co-authored-by: Bart Smykla <bartek@smykla.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants