Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp) Fix DP tracking lock consistency #2567

Merged
merged 1 commit into from
Aug 16, 2021
Merged

fix(kuma-cp) Fix DP tracking lock consistency #2567

merged 1 commit into from
Aug 16, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Aug 15, 2021

Summary

In the DataplaneLifecycle tracker, consistently lock the map that
tracks whether the dataplane has been successfully registered.

Full changelog

  • Fix a crash when multiple Dataplanes register concurrently

Issues resolved

Fix 2566

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

@jpeach jpeach requested a review from a team as a code owner August 15, 2021 23:56
In the DataplaneLifecycle tracker, consistently lock the map that
tracks whether the dataplane has been successfully registered.

This fixes #2566.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach changed the title fix(kuma-cp) Fox DP tracking lock consistency fix(kuma-cp) Fix DP tracking lock consistency Aug 16, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #2567 (733d6fa) into master (94c197e) will increase coverage by 0.01%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2567      +/-   ##
==========================================
+ Coverage   52.30%   52.32%   +0.01%     
==========================================
  Files         868      868              
  Lines       48296    48298       +2     
==========================================
+ Hits        25261    25270       +9     
+ Misses      20991    20983       -8     
- Partials     2044     2045       +1     
Impacted Files Coverage Δ
pkg/xds/server/callbacks/dataplane_lifecycle.go 67.69% <84.61%> (+8.96%) ⬆️
pkg/core/resources/store/customizable_store.go 77.77% <0.00%> (-11.12%) ⬇️
pkg/plugins/resources/memory/store.go 77.71% <0.00%> (-4.35%) ⬇️
pkg/insights/resyncer.go 65.81% <0.00%> (+0.85%) ⬆️
pkg/xds/generator/direct_access_proxy_generator.go 83.90% <0.00%> (+1.14%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94c197e...733d6fa. Read the comment docs.

@jpeach jpeach merged commit 1591de6 into kumahq:master Aug 16, 2021
@jpeach jpeach deleted the fix/lifecycle-map-write branch August 16, 2021 06:11
mergify bot pushed a commit that referenced this pull request Aug 16, 2021
In the DataplaneLifecycle tracker, consistently lock the map that
tracks whether the dataplane has been successfully registered.

This fixes #2566.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 1591de6)
jpeach added a commit that referenced this pull request Aug 16, 2021
In the DataplaneLifecycle tracker, consistently lock the map that
tracks whether the dataplane has been successfully registered.

This fixes #2566.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 1591de6)

Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants