Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kuma-cp) Intermediate CA support #2575

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Aug 16, 2021

Summary

Introduce support for Intermediate CA in Provided backend.

Full changelog

  • Remove CA validators
  • Add Intermediate CA test

Issues resolved

Fix #759

Documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2575 (889b49d) into master (fbd0831) will decrease coverage by 0.03%.
The diff coverage is 15.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2575      +/-   ##
==========================================
- Coverage   52.68%   52.65%   -0.04%     
==========================================
  Files         867      868       +1     
  Lines       48270    48336      +66     
==========================================
+ Hits        25433    25453      +20     
- Misses      20783    20828      +45     
- Partials     2054     2055       +1     
Impacted Files Coverage Δ
test/e2e/mtls/universal/mtls_backends.go 0.00% <0.00%> (ø)
pkg/plugins/ca/provided/ca_cert_validator.go 88.00% <81.25%> (-1.29%) ⬇️
pkg/core/resources/manager/cache.go 84.41% <0.00%> (+2.59%) ⬆️
app/kumactl/cmd/root.go 73.68% <0.00%> (+3.50%) ⬆️
pkg/plugins/resources/memory/store.go 82.06% <0.00%> (+4.34%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️
pkg/core/resources/store/customizable_store.go 88.88% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbd0831...889b49d. Read the comment docs.

Copy link
Contributor

@lahabana lahabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was easy to add :)

@jakubdyszkiewicz jakubdyszkiewicz merged commit dba1a9c into master Aug 17, 2021
@jakubdyszkiewicz jakubdyszkiewicz deleted the feat/intermediate-provided-ca branch August 17, 2021 13:22
mergify bot pushed a commit that referenced this pull request Aug 17, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit dba1a9c)
jakubdyszkiewicz pushed a commit that referenced this pull request Aug 17, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why the intermediate CA certificates are not allowed in "provided" CA?
3 participants