Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kuma-cp) split listener configurers across source files #2592

Merged
merged 1 commit into from
Aug 19, 2021
Merged

chore(kuma-cp) split listener configurers across source files #2592

merged 1 commit into from
Aug 19, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Aug 18, 2021

Summary

Split the listener configurers into separate source files for
listeners and filter chains to make them a bit easier to find.
Remove the unnecessary ListenerFilterChainConfigurerV3 types.

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

@jpeach jpeach requested a review from a team as a code owner August 18, 2021 04:01
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #2592 (8ecde73) into master (a0c9132) will increase coverage by 0.07%.
The diff coverage is 96.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2592      +/-   ##
==========================================
+ Coverage   52.19%   52.27%   +0.07%     
==========================================
  Files         869      869              
  Lines       48595    48593       -2     
==========================================
+ Hits        25366    25401      +35     
+ Misses      21184    21148      -36     
+ Partials     2045     2044       -1     
Impacted Files Coverage Δ
...kg/xds/envoy/listeners/filter_chain_configurers.go 97.27% <ø> (ø)
pkg/xds/envoy/listeners/listener_configurers.go 96.22% <96.22%> (ø)
api/observability/v1/mads.pb.go 35.56% <0.00%> (+1.03%) ⬆️
pkg/xds/generator/direct_access_proxy_generator.go 83.90% <0.00%> (+1.14%) ⬆️
pkg/insights/resyncer.go 65.81% <0.00%> (+1.70%) ⬆️
pkg/mads/server/server.go 84.82% <0.00%> (+1.78%) ⬆️
pkg/mads/v1/client/client.go 43.75% <0.00%> (+2.50%) ⬆️
app/kumactl/cmd/root.go 73.68% <0.00%> (+3.50%) ⬆️
pkg/plugins/resources/memory/store.go 82.06% <0.00%> (+4.34%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0c9132...8ecde73. Read the comment docs.

Split the listener configurers into separate source files for
listeners and filter chains to make them a bit easier to find.
Remove the unnecessary ListenerFilterChainConfigurerV3 types.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach merged commit 078d478 into kumahq:master Aug 19, 2021
@jpeach jpeach deleted the chore/split-listener-configurers branch August 19, 2021 00:07
mergify bot pushed a commit that referenced this pull request Aug 19, 2021
Split the listener configurers into separate source files for
listeners and filter chains to make them a bit easier to find.
Remove the unnecessary ListenerFilterChainConfigurerV3 types.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 078d478)

# Conflicts:
#	pkg/xds/envoy/listeners/filter_chain_configurers.go
jpeach added a commit that referenced this pull request Aug 19, 2021
Split the listener configurers into separate source files for
listeners and filter chains to make them a bit easier to find.
Remove the unnecessary ListenerFilterChainConfigurerV3 types.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 078d478)
jpeach added a commit that referenced this pull request Aug 19, 2021
…#2603)

Split the listener configurers into separate source files for
listeners and filter chains to make them a bit easier to find.
Remove the unnecessary ListenerFilterChainConfigurerV3 types.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 078d478)

Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants