Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*) update project to build kumactl at windows #2597

Conversation

bartsmykla
Copy link
Contributor

Summary

Update project to allow build of kumactl for windows

Full changelog

no changelog

Issues resolved

It doesn't close the "distribute" part of this issue, but at least we are able to build it now: #366

Documentation

no documentation

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla force-pushed the feat/prepare-kumactl-for-windows-compilation branch from c2538b3 to 639327a Compare August 18, 2021 14:04
Signed-off-by: Bart Smykla <bartek@smykla.com>
Signed-off-by: Bart Smykla <bartek@smykla.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #2597 (3b9dcf6) into master (81adff3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2597      +/-   ##
==========================================
+ Coverage   52.24%   52.26%   +0.01%     
==========================================
  Files         869      869              
  Lines       48593    48593              
==========================================
+ Hits        25386    25395       +9     
+ Misses      21163    21151      -12     
- Partials     2044     2047       +3     
Impacted Files Coverage Δ
...p/kumactl/cmd/install/install_transparent_proxy.go 64.79% <ø> (ø)
app/kumactl/cmd/install/install.go 100.00% <100.00%> (ø)
app/kumactl/cmd/root.go 73.68% <100.00%> (ø)
app/kumactl/cmd/uninstall/uninstall.go 100.00% <100.00%> (ø)
...mactl/cmd/uninstall/uninstall_transparent_proxy.go 59.37% <100.00%> (ø)
pkg/config/xds/bootstrap/config.go 56.75% <100.00%> (ø)
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81adff3...3b9dcf6. Read the comment docs.

pkg/config/xds/bootstrap/config.go Outdated Show resolved Hide resolved
app/kumactl/cmd/uninstall/subcommands.go Outdated Show resolved Hide resolved
Signed-off-by: Bart Smykla <bartek@smykla.com>
@bartsmykla bartsmykla requested a review from jpeach August 19, 2021 08:35
@bartsmykla bartsmykla merged commit 1fc030e into kumahq:master Aug 19, 2021
mergify bot pushed a commit that referenced this pull request Aug 19, 2021
@bartsmykla bartsmykla deleted the feat/prepare-kumactl-for-windows-compilation branch August 19, 2021 12:35
bartsmykla added a commit that referenced this pull request Aug 19, 2021
(cherry picked from commit 1fc030e)
Signed-off-by: Bart Smykla <bartek@smykla.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants