Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log): Don't set zap.Development() in debug log #2608

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

lahabana
Copy link
Contributor

@lahabana lahabana commented Aug 19, 2021

This causes DPanic log level to panic which is something we never want

Discovered in: #2594

This causes DPanic log level to panic which is something we never want

Signed-off-by: Charly Molter <charly.molter@konghq.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2608 (e1430ab) into master (81adff3) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2608      +/-   ##
==========================================
- Coverage   52.24%   52.23%   -0.01%     
==========================================
  Files         869      869              
  Lines       48593    48593              
==========================================
- Hits        25386    25383       -3     
- Misses      21163    21165       +2     
- Partials     2044     2045       +1     
Impacted Files Coverage Δ
pkg/log/logger.go 67.39% <0.00%> (ø)
pkg/insights/components.go 70.00% <0.00%> (-30.00%) ⬇️
pkg/core/resources/store/customizable_store.go 77.77% <0.00%> (-11.12%) ⬇️
pkg/plugins/resources/memory/store.go 77.71% <0.00%> (-4.35%) ⬇️
pkg/insights/resyncer.go 64.10% <0.00%> (-1.71%) ⬇️
pkg/core/resources/model/rest/resource.go 67.94% <0.00%> (-1.29%) ⬇️
pkg/core/runtime/component/component.go 84.90% <0.00%> (+3.77%) ⬆️
pkg/core/resources/manager/cache.go 84.41% <0.00%> (+5.19%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81adff3...e1430ab. Read the comment docs.

Copy link
Contributor

@jpeach jpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, we don't leverage this in testing, so it's mostly a landmine.

@lahabana lahabana merged commit 97f7d34 into kumahq:master Aug 20, 2021
mergify bot pushed a commit that referenced this pull request Aug 20, 2021
This causes DPanic log level to panic which is something we never want

Signed-off-by: Charly Molter <charly.molter@konghq.com>
(cherry picked from commit 97f7d34)
lahabana added a commit that referenced this pull request Aug 20, 2021
This causes DPanic log level to panic which is something we never want

Signed-off-by: Charly Molter <charly.molter@konghq.com>
(cherry picked from commit 97f7d34)

Co-authored-by: Charly Molter <charly.molter@konghq.com>
@lahabana lahabana deleted the fix/logging_zap_dev branch March 29, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants