feat(ci) enable Ginkgo xunit results in CircleCI #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes please :) |
Codecov Report
@@ Coverage Diff @@
## master #2652 +/- ##
==========================================
+ Coverage 51.96% 51.99% +0.02%
==========================================
Files 871 871
Lines 49505 49513 +8
==========================================
+ Hits 25727 25743 +16
+ Misses 21698 21686 -12
- Partials 2080 2084 +4
Continue to review full report at Codecov.
|
Ginkgo reporters are deprecated, pending Ginkgo V2, but it's still the only way to enable JUnit XML test reports. Enabling this in CircleCI causes the CircleCI results UI to display failing tests by name, and also collect some analytics about passing tests. Signed-off-by: James Peach <james.peach@konghq.com>
jpeach
changed the title
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2021
Ginkgo reporters are deprecated, pending Ginkgo V2, but it's still the only way to enable JUnit XML test reports. Enabling this in CircleCI causes the CircleCI results UI to display failing tests by name, and also collect some analytics about passing tests. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 4582f3e)
bartsmykla
pushed a commit
that referenced
this pull request
Aug 25, 2021
Ginkgo reporters are deprecated, pending Ginkgo V2, but it's still the only way to enable JUnit XML test reports. Enabling this in CircleCI causes the CircleCI results UI to display failing tests by name, and also collect some analytics about passing tests. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 4582f3e) Co-authored-by: James Peach <james.peach@konghq.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
Ginkgo reporters are deprecated, pending Ginkgo V2, but it's still the only way to enable JUnit XML test reports. Enabling this in CircleCI causes the CircleCI results UI to display failing tests by name, and also collect some analytics about passing tests. Signed-off-by: James Peach <james.peach@konghq.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
Ginkgo reporters are deprecated, pending Ginkgo V2, but it's still the only way to enable JUnit XML test reports. Enabling this in CircleCI causes the CircleCI results UI to display failing tests by name, and also collect some analytics about passing tests. Signed-off-by: James Peach <james.peach@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ginkgo reporters are deprecated, pending Ginkgo V2, but it's still the
only way to enable JUnit XML test reports. Enabling this in CircleCI
causes the CircleCI results UI to display failing tests by name, and
also collect some analytics about passing tests.
Full changelog
N/A
Issues resolved
N/A
Documentation
N/A
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.