Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kuma-cp) remove Envoy V2 leftovers #2686

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

jakubdyszkiewicz
Copy link
Contributor

Summary

Remove xds utils for Envoy V2 and some V2 leftovers around the code, so we can upgrade Go Control Plane

Issues resolved

No issue

Documentation

  • No docs

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • It it backwards compatible, V2 is long gone.

Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2686 (3c1a80c) into master (14b527b) will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2686      +/-   ##
==========================================
+ Coverage   51.96%   52.20%   +0.23%     
==========================================
  Files         871      864       -7     
  Lines       49505    49181     -324     
==========================================
- Hits        25727    25676      -51     
+ Misses      21698    21421     -277     
- Partials     2080     2084       +4     
Impacted Files Coverage Δ
pkg/config/xds/bootstrap/config.go 56.75% <ø> (ø)
...ore/resources/apis/mesh/proxytemplate_validator.go 96.87% <100.00%> (ø)
pkg/core/xds/resource.go 83.75% <100.00%> (-0.96%) ⬇️
app/kumactl/cmd/root.go 70.17% <0.00%> (-3.51%) ⬇️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b527b...3c1a80c. Read the comment docs.

@jakubdyszkiewicz jakubdyszkiewicz merged commit 44dab2a into master Aug 27, 2021
@jakubdyszkiewicz jakubdyszkiewicz deleted the chore/remove-v2-utils branch August 27, 2021 09:19
mergify bot pushed a commit that referenced this pull request Aug 27, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
(cherry picked from commit 44dab2a)
jakubdyszkiewicz pushed a commit that referenced this pull request Aug 27, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
nikita15p pushed a commit to nikita15p/kuma that referenced this pull request Sep 28, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
nikita15p pushed a commit to nikita15p/kuma that referenced this pull request Sep 28, 2021
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants