feat(*) automatically set proxy concurrency #2691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2691 +/- ##
==========================================
+ Coverage 52.21% 52.29% +0.08%
==========================================
Files 865 865
Lines 49299 49322 +23
==========================================
+ Hits 25741 25794 +53
+ Misses 21476 21440 -36
- Partials 2082 2088 +6
Continue to review full report at Codecov.
|
This commit adds the `--concurrency` flag to kuma-dp, which is propagated to Envoy's `--concurrency` flag. On Linux, if there is no explicit concurrency, we pass `--cpuset-threads` so that Envoy will automatically scale its worker thread if it is in a cpuset. In Kubernetes clusters, we can add additional automatic controls for the Envoy concurrency. We know the amount of CPU resource reserved for the proxy container, so we can tune that automatically. If the operator knows better, then can set an explicit concurency value with a pod annotation. This fixes #1721. Signed-off-by: James Peach <james.peach@konghq.com>
Signed-off-by: James Peach <james.peach@konghq.com>
mergify bot
pushed a commit
that referenced
this pull request
Sep 2, 2021
This commit adds the `--concurrency` flag to kuma-dp, which is propagated to Envoy's `--concurrency` flag. On Linux, if there is no explicit concurrency, we pass `--cpuset-threads` so that Envoy will automatically scale its worker thread if it is in a cpuset. In Kubernetes clusters, we can add additional automatic controls for the Envoy concurrency. We know the amount of CPU resource reserved for the proxy container, so we can tune that automatically. If the operator knows better, then can set an explicit concurency value with a pod annotation. This fixes #1721. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 1f0cf6e)
jpeach
added a commit
that referenced
this pull request
Sep 7, 2021
This commit adds the `--concurrency` flag to kuma-dp, which is propagated to Envoy's `--concurrency` flag. On Linux, if there is no explicit concurrency, we pass `--cpuset-threads` so that Envoy will automatically scale its worker thread if it is in a cpuset. In Kubernetes clusters, we can add additional automatic controls for the Envoy concurrency. We know the amount of CPU resource reserved for the proxy container, so we can tune that automatically. If the operator knows better, then can set an explicit concurency value with a pod annotation. This fixes #1721. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 1f0cf6e) Co-authored-by: James Peach <james.peach@konghq.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
This commit adds the `--concurrency` flag to kuma-dp, which is propagated to Envoy's `--concurrency` flag. On Linux, if there is no explicit concurrency, we pass `--cpuset-threads` so that Envoy will automatically scale its worker thread if it is in a cpuset. In Kubernetes clusters, we can add additional automatic controls for the Envoy concurrency. We know the amount of CPU resource reserved for the proxy container, so we can tune that automatically. If the operator knows better, then can set an explicit concurency value with a pod annotation. This fixes kumahq#1721. Signed-off-by: James Peach <james.peach@konghq.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
This commit adds the `--concurrency` flag to kuma-dp, which is propagated to Envoy's `--concurrency` flag. On Linux, if there is no explicit concurrency, we pass `--cpuset-threads` so that Envoy will automatically scale its worker thread if it is in a cpuset. In Kubernetes clusters, we can add additional automatic controls for the Envoy concurrency. We know the amount of CPU resource reserved for the proxy container, so we can tune that automatically. If the operator knows better, then can set an explicit concurency value with a pod annotation. This fixes kumahq#1721. Signed-off-by: James Peach <james.peach@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds the
--concurrencyflag to kuma-dp, which is propagatedto Envoy's
--concurrencyflag. On Linux, if there is no explicitconcurrency, we pass
--cpuset-threadsso that Envoy will automaticallyscale its worker thread if it is in a cpuset.
In Kubernetes clusters, we can add additional automatic controls for the
Envoy concurrency. We know the amount of CPU resource reserved for the
proxy container, so we can tune that automatically. If the operator knows
better, then can set an explicit concurency value with a pod annotation.
I don't expect any performance changes with this PR, since in the Kubernetes
case, the proxy container already has cgroups limits enabled. I'd be happy to
run any performance regression tests if we have them though.
Full changelog
--concurrencyflag to kum-ap for setting the number of Envoy worker threadsIssues resolved
Fix #1721
Documentation
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.