fix(dns): Ensure outbounds are set when migrating from old to new #2698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a bug when migrating from one version to the other. This is caused by the fact that we don't set OutboundEntry when migrating from old to new format. This patch: - Adds validation on VirtualOutboundView to avoid this in the future - Adds an OutboundEntry for Services with a single tag - Adds an OutboundEntry for ExternalServices by fetching back the original virtual service to retrieve its serviceName Signed-off-by: Charly Molter <charly.molter@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #2698 +/- ##
==========================================
+ Coverage 51.94% 52.04% +0.10%
==========================================
Files 871 871
Lines 49518 49543 +25
==========================================
+ Hits 25721 25784 +63
+ Misses 21716 21671 -45
- Partials 2081 2088 +7
Continue to review full report at Codecov.
|
lobkovilya
reviewed
Aug 27, 2021
pkg/dns/vips/persistence.go
Outdated
| } | ||
| srvByHost := map[string]*core_mesh.ExternalServiceResource{} | ||
| for _, s := range externalServices.Items { | ||
| srvByHost[s.Spec.GetHost()] = s |
There was a problem hiding this comment.
The host is not unique, I think you have to use networking.address here
Signed-off-by: Charly Molter <charly.molter@konghq.com>
lobkovilya
approved these changes
Aug 27, 2021
mergify bot
pushed a commit
that referenced
this pull request
Aug 27, 2021
) * fix(dns): Ensure outbounds are set when migrating from old to new There's a bug when migrating from one version to the other. This is caused by the fact that we don't set OutboundEntry when migrating from old to new format. This patch: - Adds validation on VirtualOutboundView to avoid this in the future - Adds an OutboundEntry for Services with a single tag - Adds an OutboundEntry for ExternalServices by fetching back the original virtual service to retrieve its serviceName Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit 203c072)
lahabana
added a commit
that referenced
this pull request
Aug 27, 2021
) (#2699) * fix(dns): Ensure outbounds are set when migrating from old to new There's a bug when migrating from one version to the other. This is caused by the fact that we don't set OutboundEntry when migrating from old to new format. This patch: - Adds validation on VirtualOutboundView to avoid this in the future - Adds an OutboundEntry for Services with a single tag - Adds an OutboundEntry for ExternalServices by fetching back the original virtual service to retrieve its serviceName Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit 203c072) Co-authored-by: Charly Molter <charly.molter@konghq.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
…mahq#2698) * fix(dns): Ensure outbounds are set when migrating from old to new There's a bug when migrating from one version to the other. This is caused by the fact that we don't set OutboundEntry when migrating from old to new format. This patch: - Adds validation on VirtualOutboundView to avoid this in the future - Adds an OutboundEntry for Services with a single tag - Adds an OutboundEntry for ExternalServices by fetching back the original virtual service to retrieve its serviceName Signed-off-by: Charly Molter <charly.molter@konghq.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
…mahq#2698) * fix(dns): Ensure outbounds are set when migrating from old to new There's a bug when migrating from one version to the other. This is caused by the fact that we don't set OutboundEntry when migrating from old to new format. This patch: - Adds validation on VirtualOutboundView to avoid this in the future - Adds an OutboundEntry for Services with a single tag - Adds an OutboundEntry for ExternalServices by fetching back the original virtual service to retrieve its serviceName Signed-off-by: Charly Molter <charly.molter@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There's a bug when migrating from one version to the other.
This is caused by the fact that we don't set OutboundEntry when
migrating from old to new format.
Full changelog
virtual service to retrieve its serviceName
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.