fix(kuma-cp) virtual probes with query #2706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
lahabana
reviewed
Aug 30, 2021
| testserver.WithArgs("--probes"), | ||
| testserver.WithHTTPProbes(), | ||
| )(k8sCluster)).To(Succeed()) | ||
| Eventually(testServerReady, "5s", "100ms").Should(BeTrue()) |
There was a problem hiding this comment.
This is already checked in testserver.Install no?
There was a problem hiding this comment.
There is a check framework.WaitPodsAvailable(k.opts.Namespace, k.Name()) which is okay if Pod's containers are started but not ready yet, that's why right after testserver.Instsall the situation is the following:
NAME READY STATUS RESTARTS AGE
test-server-7cbcf597ff-t5b2z 0/2 Running 0 6s
There was a problem hiding this comment.
Can we include this check in testserver.Install? This can be the problem in every usage of TestServer.
The same way VerifyKuma() should be a part of Kuma() but that's another story.
There was a problem hiding this comment.
Agree. Do you think HTTP probes should be default for test-server deployment across all e2e tests?
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #2706 +/- ##
==========================================
- Coverage 51.94% 51.88% -0.06%
==========================================
Files 871 872 +1
Lines 49518 49618 +100
==========================================
+ Hits 25721 25746 +25
- Misses 21716 21782 +66
- Partials 2081 2090 +9
Continue to review full report at Codecov.
|
…dReadyE Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
jakubdyszkiewicz
approved these changes
Sep 1, 2021
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
mergify bot
pushed a commit
that referenced
this pull request
Sep 7, 2021
* fix(kuma-cp) virtual probes with query Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> * fix(kuma-cp) make check Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> * fix(kuma-cp) use NamespaceWithSidecarInjection Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> * fix(kuma-cp) replace WaitUntilPodAvailableE with a custom WaitUntilPodReadyE Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> * fix(kuma-cp) probes are default for test-server Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> (cherry picked from commit 0bacb2a)
lobkovilya
pushed a commit
that referenced
this pull request
Sep 8, 2021
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
* fix(kuma-cp) virtual probes with query Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> * fix(kuma-cp) make check Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> * fix(kuma-cp) use NamespaceWithSidecarInjection Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> * fix(kuma-cp) replace WaitUntilPodAvailableE with a custom WaitUntilPodReadyE Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> * fix(kuma-cp) probes are default for test-server Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
* fix(kuma-cp) virtual probes with query Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> * fix(kuma-cp) make check Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> * fix(kuma-cp) use NamespaceWithSidecarInjection Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> * fix(kuma-cp) replace WaitUntilPodAvailableE with a custom WaitUntilPodReadyE Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> * fix(kuma-cp) probes are default for test-server Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When configuring readiness or liveness httpGet probes in Kubernetes
pathcould consist ofpath + query, but when configuringpathfor Envoy route matching it's strictly onlypath(withoutquery). That's why for probes withquerymatching didn't work properly.Full changelog
Issues resolved
N/A
Documentation
N/A
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.