fix(kuma-cp) test versions compatibility on the release #2707
Conversation
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #2707 +/- ##
==========================================
+ Coverage 51.93% 51.98% +0.04%
==========================================
Files 871 872 +1
Lines 49530 49553 +23
==========================================
+ Hits 25725 25759 +34
+ Misses 21724 21704 -20
- Partials 2081 2090 +9
Continue to review full report at Codecov.
|
| Entry("1.3.0", testCase{ | ||
| dpVersion: "1.3.0", | ||
| expectedEnvoyConstraint: "~1.18.4", | ||
| }), |
There was a problem hiding this comment.
I'm not sure that we need all these test cases. We don't need to verify the exact compatibility data here, we need to verify the behavior of the API by ensuring we cover all the code paths, including error cases.
There was a problem hiding this comment.
Yeah, I wasn't sure about that either but I carred the tests from the previous code location. Let me remove excessive tests
pkg/version/compatibility.go
Outdated
| }, | ||
| } | ||
|
|
||
| func (c Compatibility) DP(version string) (*KumaDPCompatibility, error) { |
There was a problem hiding this comment.
I think we can do better with the function name. This is getting the Dataplane compatibility record for the given Kuma release, right? Perhaps DataplaneConstraints could work?
There was a problem hiding this comment.
Followup ... since this API isn't used currently, do you think it is likely to be used in the future?
There was a problem hiding this comment.
It might be (for example in kumactl)
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com> (cherry picked from commit 8ae816b)
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Signed-off-by: Jakub Dyszkiewicz <jakub.dyszkiewicz@gmail.com>
Summary
In Kuma 1.3.0, we once again made a mistake of not updating
/versionsendpoint so we see a warning in the GUI.This PR introduces unit test that is executed on the release that checks if the current tag has a semver section in
CompatibilityMatrix.Full changelog
pkg/versions. This information is too important to be squeezed into API WS package. This also helps with tests.Documentation
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.