-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(*) remove circular dependency on the Istio submodule #2742
Conversation
Looks like |
The Istio submodule imports Kuma config definitions, and Kuma calls functions from the Istio submodule. Break the circular dependency by moving the config definitions into the Istio submodule, even though they more properly belong in Kuma itself. This makes it possible to run `go mod tidy` in the Istio submodule. This fixes #2087. Signed-off-by: James Peach <james.peach@konghq.com>
I see, this is just a dependency on |
Codecov Report
@@ Coverage Diff @@
## master #2742 +/- ##
==========================================
+ Coverage 51.75% 51.78% +0.03%
==========================================
Files 869 869
Lines 50649 50649
==========================================
+ Hits 26211 26228 +17
+ Misses 22351 22324 -27
- Partials 2087 2097 +10
Continue to review full report at Codecov.
|
The Istio submodule imports Kuma config definitions, and Kuma calls functions from the Istio submodule. Break the circular dependency by moving the config definitions into the Istio submodule, even though they more properly belong in Kuma itself. This makes it possible to run `go mod tidy` in the Istio submodule. This fixes #2087. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 6f2b621)
The Istio submodule imports Kuma config definitions, and Kuma calls functions from the Istio submodule. Break the circular dependency by moving the config definitions into the Istio submodule, even though they more properly belong in Kuma itself. This makes it possible to run `go mod tidy` in the Istio submodule. This fixes kumahq#2087. Signed-off-by: James Peach <james.peach@konghq.com>
The Istio submodule imports Kuma config definitions, and Kuma calls functions from the Istio submodule. Break the circular dependency by moving the config definitions into the Istio submodule, even though they more properly belong in Kuma itself. This makes it possible to run `go mod tidy` in the Istio submodule. This fixes kumahq#2087. Signed-off-by: James Peach <james.peach@konghq.com>
Summary
The Istio submodule imports Kuma config definitions, and Kuma calls
functions from the Istio submodule. Break the circular dependency by
moving the config definitions into the Istio submodule, even though
they more properly belong in Kuma itself.
This makes it possible to run
go mod tidy
in the Istio submodule.Full changelog
N/A
Issues resolved
Fix #2087.
Documentation
N/A
Testing
Backwards compatibility
backport-to-stable
label if the code is backwards compatible. Otherwise, list breaking changes.