fix(*) switch Gateway to a selectors field #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpeach
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2749 +/- ##
==========================================
+ Coverage 51.93% 51.97% +0.03%
==========================================
Files 877 877
Lines 51141 51139 -2
==========================================
+ Hits 26561 26579 +18
+ Misses 22472 22445 -27
- Partials 2108 2115 +7
Continue to review full report at Codecov.
|
lahabana
approved these changes
Sep 8, 2021
A Gateway matches a dataplane directly; it doesn't match a traffic flow. This means that a `selectors` field is more direct and consistent with the Kuma API than a `sources` field. Signed-off-by: James Peach <james.peach@konghq.com>
mergify bot
pushed a commit
that referenced
this pull request
Sep 9, 2021
A Gateway matches a dataplane directly; it doesn't match a traffic flow. This means that a `selectors` field is more direct and consistent with the Kuma API than a `sources` field. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 858034a)
jpeach
added a commit
that referenced
this pull request
Sep 9, 2021
A Gateway matches a dataplane directly; it doesn't match a traffic flow. This means that a `selectors` field is more direct and consistent with the Kuma API than a `sources` field. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 858034a) Co-authored-by: James Peach <james.peach@konghq.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
A Gateway matches a dataplane directly; it doesn't match a traffic flow. This means that a `selectors` field is more direct and consistent with the Kuma API than a `sources` field. Signed-off-by: James Peach <james.peach@konghq.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
A Gateway matches a dataplane directly; it doesn't match a traffic flow. This means that a `selectors` field is more direct and consistent with the Kuma API than a `sources` field. Signed-off-by: James Peach <james.peach@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A Gateway matches a dataplane directly; it doesn't match a traffic flow.
This means that a
selectorsfield is more direct and consistent withthe Kuma API than a
sourcesfield.Full changelog
N/A
Issues resolved
N/A
Documentation
N/A
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.