fix(kuma-cp) fault injection matching

[lobkovilya]

Summary

Today if you apply 2 Fault Injections:

type: FaultInjection
mesh: default
name: fi1
sources:
   - match:
       kuma.io/service: demo-client-1
destinations:
   - match:
       kuma.io/service: test-server
       kuma.io/protocol: http
conf:
   abort:
     httpStatus: 401
     percentage: 100
---
type: FaultInjection
mesh: default
name: fi2
sources:
   - match:
       kuma.io/service: demo-client-2
destinations:
   - match:
       kuma.io/service: test-server
       kuma.io/protocol: http
conf:
   abort:
     httpStatus: 402
     percentage: 100

Only the latest one will be applied and replace another one.

Full changelog

• Select all matched policies for the inbound and apply them all. We can do that because we rely on the HttpFault header matching

Issues resolved

N/A

Documentation

• Link to the website documentation PR

Testing

• Unit tests
• E2E tests
• Manual testing on Universal
• Manual testing on Kubernetes

Backwards compatibility

• Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

[codecov-commenter]

Codecov Report

Merging #2757 (0a77b1f) into master (6f2b621) will increase coverage by 0.01%.
The diff coverage is 25.23%.

@@            Coverage Diff             @@
##           master    #2757      +/-   ##
==========================================
+ Coverage   51.93%   51.94%   +0.01%     
==========================================
  Files         877      878       +1     
  Lines       51141    51219      +78     
==========================================
+ Hits        26561    26607      +46     
- Misses      22472    22494      +22     
- Partials     2108     2118      +10     

Impacted Files	Coverage Δ
pkg/core/xds/types.go	89.65% <ø> (ø)
test/e2e/matching/matching_universal.go	0.00% <0.00%> (ø)
pkg/xds/generator/inbound_proxy_generator.go	74.77% <50.00%> (ø)
...s/envoy/listeners/v3/fault_injection_configurer.go	71.01% <83.33%> (+0.86%)	⬆️
pkg/core/faultinjections/matcher.go	78.94% <100.00%> (+1.16%)	⬆️
...kg/xds/envoy/listeners/filter_chain_configurers.go	97.29% <100.00%> (ø)
pkg/xds/generator/direct_access_proxy_generator.go	82.75% <0.00%> (-1.15%)	⬇️
...kg/core/resources/apis/mesh/generated_resources.go	78.56% <0.00%> (+0.20%)	⬆️
api/observability/v1/mads.pb.go	35.56% <0.00%> (+1.03%)	⬆️
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f2b621...0a77b1f. Read the comment docs.

[lahabana]

Nice!

[jpeach]

This approach is great.

I'm a bit concerned about the performance impact of running a bunch of complex regexes on every request, but that's not new in this PR.

[lahabana]

Remember to update the docs :)

[jakubdyszkiewicz]

Backwards compatibility
[ ] Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

please put a comment whether this meant to be backported or not

[lobkovilya]

@lahabana that was kind of already declared by docs, but I replaced old-formated yaml with tabs kumahq/kuma-website#535