fix(*) send tool output to stdout #2787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cobra defaults to writing all output to stderr. Change each root command to set the standard output stream to stdout so that normal and error output is separated as expected. This fixes #2786. Signed-off-by: James Peach <james.peach@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #2787 +/- ##
==========================================
+ Coverage 52.07% 52.14% +0.07%
==========================================
Files 880 880
Lines 51260 51263 +3
==========================================
+ Hits 26692 26732 +40
+ Misses 22460 22410 -50
- Partials 2108 2121 +13
Continue to review full report at Codecov.
|
|
why would Cobra make such a change? |
jakubdyszkiewicz
approved these changes
Sep 20, 2021
jpeach
added a commit
that referenced
this pull request
Sep 20, 2021
Cobra defaults to writing all output to stderr. Change each root command to set the standard output stream to stdout so that normal and error output is separated as expected. This fixes #2786. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit a9245c5) Co-authored-by: James Peach <james.peach@konghq.com>
lahabana
pushed a commit
to lahabana/kuma
that referenced
this pull request
Sep 21, 2021
Cobra defaults to writing all output to stderr. Change each root command to set the standard output stream to stdout so that normal and error output is separated as expected. This fixes kumahq#2786. Signed-off-by: James Peach <james.peach@konghq.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
Cobra defaults to writing all output to stderr. Change each root command to set the standard output stream to stdout so that normal and error output is separated as expected. This fixes kumahq#2786. Signed-off-by: James Peach <james.peach@konghq.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
Cobra defaults to writing all output to stderr. Change each root command to set the standard output stream to stdout so that normal and error output is separated as expected. This fixes kumahq#2786. Signed-off-by: James Peach <james.peach@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cobra defaults to writing all output to stderr. Change each root command
to set the standard output stream to stdout so that normal and error
output is separated as expected.
Full changelog
Issues resolved
Fix #2786
Documentation
N/A
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.