chore(*) migrate from closed channel to context for app lifetime #2804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required because newer versions of the controller-runtime will rely on context instead of a closed channel to indicate that the app should shutdown Signed-off-by: Charly Molter <charly.molter@konghq.com>
|
Related to #2764 |
Codecov Report
@@ Coverage Diff @@
## master #2804 +/- ##
==========================================
+ Coverage 52.04% 52.08% +0.03%
==========================================
Files 882 882
Lines 51320 51321 +1
==========================================
+ Hits 26708 26728 +20
+ Misses 22490 22469 -21
- Partials 2122 2124 +2
Continue to review full report at Codecov.
|
jpeach
approved these changes
Sep 21, 2021
| @@ -84,11 +84,11 @@ func (r *PodReconciler) Reconcile(req kube_ctrl.Request) (kube_ctrl.Result, erro | |||
| if pod.Namespace != r.SystemNamespace { | |||
| return kube_ctrl.Result{}, errors.Errorf("Ingress can only be deployed in system namespace %q", r.SystemNamespace) | |||
| } | |||
| services, err := r.findMatchingServices(pod) | |||
| services, err := r.findMatchingServices(ctx, pod) | |||
There was a problem hiding this comment.
Rather than passing the context down everywhere, what about making it a public member of PodReconciler, and if it isn't already set in Reconcile, initialize it to context.Background() there.
There was a problem hiding this comment.
In the upgrade to the next version of controller-runtime this method becomes Reconcile(ctx, req) so knowing this I'd rather keep it this way.
| @@ -178,7 +179,8 @@ var _ = Describe("Dataplane Lifecycle", func() { | |||
| err := callbacks.OnStreamRequest(streamId, &req) | |||
| Expect(err).ToNot(HaveOccurred()) | |||
|
|
|||
| close(shutdown) | |||
| cancel() | |||
| cancel() | |||
Signed-off-by: Charly Molter <charly.molter@konghq.com>
jakubdyszkiewicz
approved these changes
Sep 21, 2021
Signed-off-by: Charly Molter <charly.molter@konghq.com>
mergify bot
pushed a commit
that referenced
this pull request
Sep 21, 2021
This is required because newer versions of the controller-runtime will rely on context instead of a closed channel to indicate that the app should shutdown Signed-off-by: Charly Molter <charly.molter@konghq.com> (cherry picked from commit 09949cf) # Conflicts: # .golangci.yml
jakubdyszkiewicz
pushed a commit
that referenced
this pull request
Sep 27, 2021
This is required because newer versions of the controller-runtime will rely on context instead of a closed channel to indicate that the app should shutdown Signed-off-by: Charly Molter <charly.molter@konghq.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
…ahq#2804) This is required because newer versions of the controller-runtime will rely on context instead of a closed channel to indicate that the app should shutdown Signed-off-by: Charly Molter <charly.molter@konghq.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
…ahq#2804) This is required because newer versions of the controller-runtime will rely on context instead of a closed channel to indicate that the app should shutdown Signed-off-by: Charly Molter <charly.molter@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required because newer versions of the controller-runtime
will rely on context instead of a closed channel to indicate that
the app should shutdown
Signed-off-by: Charly Molter charly.molter@konghq.com
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.