fix(kuma-cp) Apply ratelimit to service insights #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
mergify bot
pushed a commit
that referenced
this pull request
Sep 22, 2021
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com> (cherry picked from commit 4cf589d)
bartsmykla
pushed a commit
that referenced
this pull request
Sep 24, 2021
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
Signed-off-by: Paul Parkanzky <paul.parkanzky@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Paul Parkanzky paul.parkanzky@konghq.com
Summary
Service insights were being applied prior to checking rate limit. Moved the rate limit check up so that it would apply to both service and mesh insight generation.
Full changelog
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.