fix(kumactl) Only warn about version compatibility where it makes sense #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelbeaumont
force-pushed
the
fix/version_warning
branch
4 times, most recently
from
081d4bb
to
90f74a9
Compare
Codecov Report
@@ Coverage Diff @@
## master #2828 +/- ##
==========================================
+ Coverage 52.01% 52.04% +0.03%
==========================================
Files 882 883 +1
Lines 51321 51358 +37
==========================================
+ Hits 26694 26731 +37
+ Misses 22514 22495 -19
- Partials 2113 2132 +19
Continue to review full report at Codecov.
|
michaelbeaumont
force-pushed
the
fix/version_warning
branch
from
90f74a9
to
667c3d2
Compare
2 tasks
Also remove logging with the k8s logger Signed-off-by: Michael Beaumont <mjboamail@gmail.com>
Warn for: apply, delete, generate, get, inspect Don't warn for: completion, config, install, uninstall, version Signed-off-by: Michael Beaumont <mjboamail@gmail.com>
michaelbeaumont
force-pushed
the
fix/version_warning
branch
from
667c3d2
to
877a100
Compare
|
Nice, that's much better. I'm a bit hesitant whether to include checks in like it was suggested on the planning. That's a separate PR, but since we don't have a warning on kumactl version, it would be great to have server version explicit in kumactl |
jakubdyszkiewicz
approved these changes
Sep 24, 2021
|
(please make sure to backport it) |
Completely agree, I'm going to add this. |
mergify bot
pushed a commit
that referenced
this pull request
Sep 24, 2021
…se (#2828) * fix(kumactl) Add method to check server version compatibility Also remove logging with the k8s logger Signed-off-by: Michael Beaumont <mjboamail@gmail.com> * fix(kumactl) Only warn about version compatibility where it makes sense Warn for: apply, delete, generate, get, inspect Don't warn for: completion, config, install, uninstall, version Signed-off-by: Michael Beaumont <mjboamail@gmail.com> (cherry picked from commit 4bf896a)
michaelbeaumont
added a commit
that referenced
this pull request
Sep 24, 2021
…se (#2828) * fix(kumactl) Add method to check server version compatibility Also remove logging with the k8s logger Signed-off-by: Michael Beaumont <mjboamail@gmail.com> * fix(kumactl) Only warn about version compatibility where it makes sense Warn for: apply, delete, generate, get, inspect Don't warn for: completion, config, install, uninstall, version Signed-off-by: Michael Beaumont <mjboamail@gmail.com> (cherry picked from commit 4bf896a) Signed-off-by: Mike <2266568+michaelbeaumont@users.noreply.github.com>
michaelbeaumont
added a commit
that referenced
this pull request
Sep 26, 2021
…se (#2828) (#2833) * fix(kumactl) Add method to check server version compatibility Also remove logging with the k8s logger Signed-off-by: Michael Beaumont <mjboamail@gmail.com> * fix(kumactl) Only warn about version compatibility where it makes sense Warn for: apply, delete, generate, get, inspect Don't warn for: completion, config, install, uninstall, version Signed-off-by: Michael Beaumont <mjboamail@gmail.com> (cherry picked from commit 4bf896a) Signed-off-by: Mike <2266568+michaelbeaumont@users.noreply.github.com> Co-authored-by: Mike <2266568+michaelbeaumont@users.noreply.github.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
…se (kumahq#2828) * fix(kumactl) Add method to check server version compatibility Also remove logging with the k8s logger Signed-off-by: Michael Beaumont <mjboamail@gmail.com> * fix(kumactl) Only warn about version compatibility where it makes sense Warn for: apply, delete, generate, get, inspect Don't warn for: completion, config, install, uninstall, version Signed-off-by: Michael Beaumont <mjboamail@gmail.com>
nikita15p
pushed a commit
to nikita15p/kuma
that referenced
this pull request
Sep 28, 2021
…se (kumahq#2828) * fix(kumactl) Add method to check server version compatibility Also remove logging with the k8s logger Signed-off-by: Michael Beaumont <mjboamail@gmail.com> * fix(kumactl) Only warn about version compatibility where it makes sense Warn for: apply, delete, generate, get, inspect Don't warn for: completion, config, install, uninstall, version Signed-off-by: Michael Beaumont <mjboamail@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix(kumactl) Only warn about version compatibility where it makes sense
Warn for: apply, delete, generate, get, inspect
Don't warn for: completion, config, install, uninstall, version
Full changelog
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.