feat(kumactl) print control plane version with version cmd #2834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Beaumont <mjboamail@gmail.com>
michaelbeaumont
force-pushed
the
feat/server_version
branch
from
40a26a6
to
0021107
Compare
Codecov Report
@@ Coverage Diff @@
## master #2834 +/- ##
==========================================
+ Coverage 52.01% 52.08% +0.07%
==========================================
Files 882 883 +1
Lines 51321 51350 +29
==========================================
+ Hits 26694 26747 +53
+ Misses 22514 22474 -40
- Partials 2113 2129 +16
Continue to review full report at Codecov.
|
parkanzky
reviewed
Sep 24, 2021
app/kumactl/cmd/version/version.go
Outdated
| } | ||
|
|
||
| if kumaCPInfo != nil { | ||
| cmd.Printf("kuma-cp: %s\n", kumaCPInfo.Version) |
There was a problem hiding this comment.
This should probably include the product as well, so the user knows if they are using Kuma kumactl with Kong Mesh kuma-cp.
There was a problem hiding this comment.
how about
Client: Kuma 1.2.3
Server: Kuma 1.2.4
?
There was a problem hiding this comment.
Yeah, and if the server is kong mesh -
Client: Kuma 1.2.3
Server: Kong Mesh 1.4.0
parkanzky
approved these changes
Sep 24, 2021
|
@michaelbeaumont Pretty sure that this change is OK for the 1.3 release branch, in which case, apply the |
lobkovilya
reviewed
Sep 27, 2021
| @@ -111,7 +111,7 @@ func NewRootCmd(root *kumactl_cmd.RootContext) *cobra.Command { | |||
| cmd.AddCommand(inspect.NewInspectCmd(root)) | |||
| cmd.AddCommand(install.NewInstallCmd(root)) | |||
| cmd.AddCommand(uninstall.NewUninstallCmd()) | |||
| cmd.AddCommand(version.NewVersionCmd()) | |||
| cmd.AddCommand(version.NewCmd(root)) | |||
There was a problem hiding this comment.
So we gonna have 2 version command: github.com/kumahq/kuma/app/kumactl/cmd/version and github.com/kumahq/kuma/pkg/cmd/version? Maybe we can create method BuildInfo.Print, to have this formatting in one place:
cmd.Println(fmt.Sprintf("Product: %s", kuma_version.Product))
cmd.Println(fmt.Sprintf("Version: %s", buildInfo.Version))
cmd.Println(fmt.Sprintf("Git Tag: %s", buildInfo.GitTag))
cmd.Println(fmt.Sprintf("Git Commit: %s", buildInfo.GitCommit))
cmd.Println(fmt.Sprintf("Build Date: %s", buildInfo.BuildDate))
michaelbeaumont
force-pushed
the
feat/server_version
branch
3 times, most recently
from
a62bb1e
to
f57fe2f
Compare
Signed-off-by: Michael Beaumont <mjboamail@gmail.com>
Signed-off-by: Michael Beaumont <mjboamail@gmail.com>
michaelbeaumont
force-pushed
the
feat/server_version
branch
from
f57fe2f
to
a9377d8
Compare
michaelbeaumont
requested review from
lobkovilya,
jakubdyszkiewicz and
parkanzky
lobkovilya
approved these changes
Sep 28, 2021
mergify bot
pushed a commit
that referenced
this pull request
Sep 29, 2021
* feat(kumactl) print control plane version with version cmd Signed-off-by: Michael Beaumont <mjboamail@gmail.com> * feat(kumactl) display server product and add Client/Server prefix Signed-off-by: Michael Beaumont <mjboamail@gmail.com> * refactor(kumactl) deduplicate version printing code Signed-off-by: Michael Beaumont <mjboamail@gmail.com> (cherry picked from commit df0b186)
michaelbeaumont
added a commit
that referenced
this pull request
Sep 29, 2021
* feat(kumactl) print control plane version with version cmd Signed-off-by: Michael Beaumont <mjboamail@gmail.com> * feat(kumactl) display server product and add Client/Server prefix Signed-off-by: Michael Beaumont <mjboamail@gmail.com> * refactor(kumactl) deduplicate version printing code Signed-off-by: Michael Beaumont <mjboamail@gmail.com> Signed-off-by: Mike <mjboamail@gmail.com> (cherry picked from commit df0b186)
michaelbeaumont
added a commit
that referenced
this pull request
Sep 29, 2021
…2850) * feat(kumactl) print control plane version with version cmd Signed-off-by: Michael Beaumont <mjboamail@gmail.com> * feat(kumactl) display server product and add Client/Server prefix Signed-off-by: Michael Beaumont <mjboamail@gmail.com> * refactor(kumactl) deduplicate version printing code Signed-off-by: Michael Beaumont <mjboamail@gmail.com> Signed-off-by: Mike <mjboamail@gmail.com> (cherry picked from commit df0b186) Co-authored-by: Mike <mjboamail@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
versionsubcommand now prints the control plane version.Full changelog
versioncommand outputTesting
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.