Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kumactl) migrate install resources from rbac API v1beta1 to v1 #2875

Merged
merged 2 commits into from
Oct 4, 2021

Conversation

michaelbeaumont
Copy link
Contributor

@michaelbeaumont michaelbeaumont commented Oct 4, 2021

Summary

This version was removed in k8s v1.22 which makes using the install command difficult, v1 has been available since k8s 1.8.

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

@michaelbeaumont michaelbeaumont requested a review from a team as a code owner October 4, 2021 08:28
This version was removed in k8s v1.22, v1 available since 1.8

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2021

Codecov Report

Merging #2875 (3dbca41) into master (92afc6c) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2875      +/-   ##
==========================================
+ Coverage   52.40%   52.44%   +0.04%     
==========================================
  Files         899      899              
  Lines       52085    52085              
==========================================
+ Hits        27294    27315      +21     
+ Misses      22624    22596      -28     
- Partials     2167     2174       +7     
Impacted Files Coverage Δ
pkg/core/resources/manager/cache.go 81.81% <0.00%> (-2.60%) ⬇️
pkg/core/resources/model/rest/resource.go 69.23% <0.00%> (+1.28%) ⬆️
pkg/insights/resyncer.go 67.16% <0.00%> (+2.98%) ⬆️
pkg/events/eventbus.go 92.59% <0.00%> (+7.40%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️
pkg/insights/components.go 100.00% <0.00%> (+30.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92afc6c...3dbca41. Read the comment docs.

@michaelbeaumont michaelbeaumont merged commit 6121d9d into kumahq:master Oct 4, 2021
@michaelbeaumont michaelbeaumont deleted the chore/rbac-v1 branch October 4, 2021 15:14
mergify bot pushed a commit that referenced this pull request Oct 4, 2021
…2875)

* chore(kumactl) migrate install resources from rbac API v1beta1 to v1

This version was removed in k8s v1.22, v1 available since 1.8

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>

* tests(integration) include kumactl install rbac version migration

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
(cherry picked from commit 6121d9d)
michaelbeaumont added a commit that referenced this pull request Oct 4, 2021
…2875) (#2885)

* chore(kumactl) migrate install resources from rbac API v1beta1 to v1

This version was removed in k8s v1.22, v1 available since 1.8

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>

* tests(integration) include kumactl install rbac version migration

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
(cherry picked from commit 6121d9d)

Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants