Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics) add zone selector to Kuma Service to Service dashboard #2876

Merged

Conversation

michaelbeaumont
Copy link
Contributor

Summary

Add Zone selector to the Service to Service dashboard:
service_service-zone_selector

standalone:
service_service-zone_selector_standalone

Testing

  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
@michaelbeaumont michaelbeaumont requested a review from a team as a code owner October 4, 2021 08:59
@codecov-commenter
Copy link

Codecov Report

Merging #2876 (284dbf8) into master (92afc6c) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2876      +/-   ##
==========================================
+ Coverage   52.40%   52.44%   +0.04%     
==========================================
  Files         899      899              
  Lines       52085    52085              
==========================================
+ Hits        27294    27318      +24     
+ Misses      22624    22595      -29     
- Partials     2167     2172       +5     
Impacted Files Coverage Δ
pkg/core/resources/manager/cache.go 81.81% <0.00%> (-2.60%) ⬇️
pkg/xds/generator/direct_access_proxy_generator.go 82.75% <0.00%> (-1.15%) ⬇️
api/observability/v1/mads.pb.go 35.56% <0.00%> (+1.03%) ⬆️
pkg/core/resources/model/rest/resource.go 69.23% <0.00%> (+1.28%) ⬆️
pkg/mads/v1/client/client.go 43.75% <0.00%> (+2.50%) ⬆️
pkg/insights/resyncer.go 67.16% <0.00%> (+2.98%) ⬆️
pkg/events/eventbus.go 92.59% <0.00%> (+7.40%) ⬆️
pkg/core/bootstrap/autoconfig.go 54.46% <0.00%> (+8.03%) ⬆️
pkg/insights/components.go 100.00% <0.00%> (+30.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92afc6c...284dbf8. Read the comment docs.

@michaelbeaumont michaelbeaumont merged commit 83aa28d into kumahq:master Oct 4, 2021
@michaelbeaumont michaelbeaumont deleted the feat/kuma-service-service-zone branch October 4, 2021 17:06
mergify bot pushed a commit that referenced this pull request Oct 4, 2021
…2876)

* feat(metrics) add zone selector to Kuma Service to Service dashboard

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>

* tests(integration) include Kuma Service to Service zone changes in test

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
(cherry picked from commit 83aa28d)
michaelbeaumont added a commit that referenced this pull request Oct 4, 2021
…2876) (#2887)

* feat(metrics) add zone selector to Kuma Service to Service dashboard

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>

* tests(integration) include Kuma Service to Service zone changes in test

Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
(cherry picked from commit 83aa28d)

Co-authored-by: Mike Beaumont <mjboamail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants