fix(kuma-cp) disable zone #2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
| consecutive = 0 | ||
| } | ||
| return consecutive == 20 | ||
| }, "30s", "10ms").Should(BeTrue()) |
There was a problem hiding this comment.
I think you should use CollectResponsesByInstance instead of rebuilding the logic.
jakubdyszkiewicz
approved these changes
Oct 4, 2021
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #2884 +/- ##
=======================================
Coverage 52.31% 52.31%
=======================================
Files 900 900
Lines 52295 52315 +20
=======================================
+ Hits 27356 27369 +13
- Misses 22761 22767 +6
- Partials 2178 2179 +1
Continue to review full report at Codecov.
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 5, 2021
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> (cherry picked from commit 9fffa21)
lobkovilya
added a commit
that referenced
this pull request
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A bug that didn't allow users to disable a zone.
Full changelog
Issues resolved
N/A
Documentation
N/A
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.