chore(kuma-dp) improve envoy startup logging #2899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a spelling error in the envoy version detection logging by changing the log message to be more succinct, and in the case of a startup error, use consistent log tags to show the envoy path and arguments. Signed-off-by: James Peach <james.peach@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #2899 +/- ##
==========================================
+ Coverage 52.14% 52.17% +0.03%
==========================================
Files 897 897
Lines 52069 52069
==========================================
+ Hits 27150 27168 +18
+ Misses 22748 22730 -18
Partials 2171 2171
Continue to review full report at Codecov.
|
michaelbeaumont
approved these changes
Oct 6, 2021
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2021
Fix a spelling error in the envoy version detection logging by changing the log message to be more succinct, and in the case of a startup error, use consistent log tags to show the envoy path and arguments. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 2d30276)
jpeach
added a commit
that referenced
this pull request
Oct 7, 2021
Fix a spelling error in the envoy version detection logging by changing the log message to be more succinct, and in the case of a startup error, use consistent log tags to show the envoy path and arguments. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 2d30276) Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix a spelling error in the envoy version detection logging by changing
the log message to be more succinct, and in the case of a startup error,
use consistent log tags to show the envoy path and arguments.
Full changelog
N/A
Issues resolved
N/A
Documentation
N/A
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.