fix(kuma-cp) locality-aware lb for external-services #2903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
| @@ -57,9 +60,12 @@ networking: | |||
| // External Service non-Kuma Cluster | |||
| external = clusters.GetCluster(Kuma3) | |||
|
|
|||
| // todo(lobkovilya): use test-server as an external service | |||
There was a problem hiding this comment.
Is it a lot of work? Would it be possible to do it now? If now, can we create a card for this?
There was a problem hiding this comment.
We deploy test-server always with a sidecar, so it's not as easy as just using TestServerUniversal(...). I'd better create a new issue for that
|
Docs are in progress |
jakubdyszkiewicz
approved these changes
Oct 7, 2021
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2021
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com> (cherry picked from commit ec05784)
lobkovilya
added a commit
that referenced
this pull request
Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If locality-aware load balancing is enabled, we should respect
kuma.io/zonetags on external services.Full changelog
kuma.io/zoneIssues resolved
N/A
Documentation
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.