chore(*) remove test framework pod readiness utility #2917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is already a helper in terratest to wait for a pod to become ready, so we can just call that with some extra logging, rather han re-implementing it in the test framework. Signed-off-by: James Peach <james.peach@konghq.com>
Codecov Report
@@ Coverage Diff @@
## master #2917 +/- ##
==========================================
+ Coverage 52.13% 52.17% +0.03%
==========================================
Files 897 897
Lines 52070 52053 -17
==========================================
+ Hits 27149 27159 +10
+ Misses 22749 22720 -29
- Partials 2172 2174 +2
Continue to review full report at Codecov.
|
jakubdyszkiewicz
approved these changes
Oct 7, 2021
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2021
There is already a helper in terratest to wait for a pod to become ready, so we can just call that with some extra logging, rather han re-implementing it in the test framework. Signed-off-by: James Peach <james.peach@konghq.com> (cherry picked from commit 7b03a30)
jakubdyszkiewicz
pushed a commit
that referenced
this pull request
Oct 7, 2021
There is already a helper in terratest to wait for a pod to become ready, so we can just call that with some extra logging, rather han re-implementing it in the test framework. Signed-off-by: James Peach <james.peach@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There is already a helper in terratest to wait for a pod to become
ready, so we can just call that with some extra logging, rather han
re-implementing it in the test framework.
Full changelog
N/A
Issues resolved
N/A
Documentation
N/A
Testing
Backwards compatibility
backport-to-stablelabel if the code is backwards compatible. Otherwise, list breaking changes.