Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kuma-cp) enable secrets support for Gateway resources #2953

Merged
merged 1 commit into from
Oct 21, 2021
Merged

fix(kuma-cp) enable secrets support for Gateway resources #2953

merged 1 commit into from
Oct 21, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Oct 14, 2021

Summary

Add the secrets generator to the Gateway proxy template. This fixes
mTLS between the gateway proxy and upstream services in the mesh.

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #2953 (d7f41d3) into master (f131b07) will decrease coverage by 0.08%.
The diff coverage is 0.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2953      +/-   ##
==========================================
- Coverage   52.37%   52.29%   -0.09%     
==========================================
  Files         912      912              
  Lines       52584    52723     +139     
==========================================
+ Hits        27542    27571      +29     
- Misses      22849    22954     +105     
- Partials     2193     2198       +5     
Impacted Files Coverage Δ
test/e2e/gateway/gateway_universal.go 0.00% <0.00%> (ø)
test/e2e/trafficroute/testutil/collect.go 0.00% <0.00%> (ø)
test/framework/interface.go 0.00% <0.00%> (ø)
test/framework/k8s_cluster.go 0.00% <0.00%> (ø)
test/framework/k8s_controlplane.go 0.00% <0.00%> (ø)
test/framework/kumactl.go 0.00% <0.00%> (ø)
test/framework/universal_app.go 0.00% <0.00%> (ø)
test/framework/universal_cluster.go 0.00% <0.00%> (ø)
test/framework/universal_controlplane.go 0.00% <0.00%> (ø)
pkg/plugins/runtime/gateway/plugin.go 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f131b07...d7f41d3. Read the comment docs.

@jpeach jpeach changed the title Feat/mtls gateway support The Content-Type of the requested document, if there was any. Oct 14, 2021
@jpeach jpeach changed the title The Content-Type of the requested document, if there was any. fix(kuma-cp) enable secrets support for Gateway resources Oct 14, 2021
@jpeach jpeach marked this pull request as ready for review October 14, 2021 07:02
@jpeach jpeach requested a review from a team as a code owner October 14, 2021 07:02
Add the secrets generator to the Gateway proxy template. This fixes
mTLS between the gageway proxy and upstream services in the mesh.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach merged commit 68d5186 into kumahq:master Oct 21, 2021
mergify bot pushed a commit that referenced this pull request Oct 21, 2021
Add the secrets generator to the Gateway proxy template. This fixes
mTLS between the gageway proxy and upstream services in the mesh.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 68d5186)

# Conflicts:
#	test/framework/interface.go
#	test/framework/kumactl.go
#	test/framework/universal_cluster.go
@jpeach jpeach deleted the feat/mtls-gateway-support branch October 21, 2021 22:54
jpeach added a commit that referenced this pull request Oct 25, 2021
Add the secrets generator to the Gateway proxy template. This fixes
mTLS between the gageway proxy and upstream services in the mesh.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 68d5186)
jpeach added a commit that referenced this pull request Oct 25, 2021
)

Add the secrets generator to the Gateway proxy template. This fixes
mTLS between the gageway proxy and upstream services in the mesh.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 68d5186)

Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants