Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*) update Go build comments #2978

Merged
merged 1 commit into from
Oct 20, 2021
Merged

chore(*) update Go build comments #2978

merged 1 commit into from
Oct 20, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Oct 20, 2021

Summary

Running "make check" with Go 1.17 updates the build comments. These
comments are harmless to earlier Go releases.

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Running "make check" with Go 1.17 updates the build comments. These
comments are harmless to earlier Go releases.

Signed-off-by: James Peach <james.peach@konghq.com>
Copy link
Contributor

@bartsmykla bartsmykla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jpeach jpeach marked this pull request as ready for review October 20, 2021 04:22
@jpeach jpeach requested a review from a team as a code owner October 20, 2021 04:22
@codecov-commenter
Copy link

Codecov Report

Merging #2978 (6ef198d) into master (704c57c) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2978      +/-   ##
==========================================
+ Coverage   52.33%   52.37%   +0.04%     
==========================================
  Files         912      912              
  Lines       52583    52583              
==========================================
+ Hits        27517    27539      +22     
+ Misses      22876    22846      -30     
- Partials     2190     2198       +8     
Impacted Files Coverage Δ
...p/kumactl/cmd/install/install_transparent_proxy.go 64.79% <ø> (ø)
...mactl/cmd/uninstall/uninstall_transparent_proxy.go 59.37% <ø> (ø)
...resources/apis/mesh/dataplane_validator_gateway.go 100.00% <ø> (ø)
pkg/plugins/runtime/gateway/enabled.go 100.00% <ø> (ø)
pkg/plugins/runtime/gateway/register/enabled.go 100.00% <ø> (ø)
pkg/util/os/limits.go 68.42% <ø> (ø)
pkg/plugins/leader/postgres/leader_elector.go 93.61% <0.00%> (-4.26%) ⬇️
pkg/core/resources/manager/cache.go 83.11% <0.00%> (-2.60%) ⬇️
pkg/insights/resyncer.go 68.08% <0.00%> (+2.83%) ⬆️
pkg/events/eventbus.go 92.59% <0.00%> (+7.40%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704c57c...6ef198d. Read the comment docs.

@jpeach jpeach merged commit e5f3245 into kumahq:master Oct 20, 2021
@jpeach jpeach deleted the chore/update-go-comments branch October 20, 2021 04:57
mergify bot pushed a commit that referenced this pull request Oct 20, 2021
Running "make check" with Go 1.17 updates the build comments. These
comments are harmless to earlier Go releases.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit e5f3245)
jpeach added a commit that referenced this pull request Oct 20, 2021
Running "make check" with Go 1.17 updates the build comments. These
comments are harmless to earlier Go releases.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit e5f3245)

Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants