fix(tests) restore WithCtlOpt to test/framework #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Beaumont <mjboamail@gmail.com>
jakubdyszkiewicz
approved these changes
Oct 21, 2021
|
@michaelbeaumont I guess this was in the original code, but this it only for kubectl options? If so, we should name it like that or at least mention in the godoc. |
mergify bot
pushed a commit
that referenced
this pull request
Oct 25, 2021
Signed-off-by: Mike Beaumont <mjboamail@gmail.com> (cherry picked from commit c858836)
jpeach
pushed a commit
that referenced
this pull request
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This function is useful for using
test/frameworkelsewhere, when additional options have been added to the executable.