Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(kuma-cp) deconstruct filter chain match configurers #3037

Merged
merged 1 commit into from
Nov 2, 2021
Merged

chore(kuma-cp) deconstruct filter chain match configurers #3037

merged 1 commit into from
Nov 2, 2021

Conversation

jpeach
Copy link
Contributor

@jpeach jpeach commented Oct 28, 2021

Summary

Deconstruct the FilterChainMatch configurer so that match fields can
be populated individually. Renamed the source address matcher to be
consistent with the rest of the API.

Full changelog

N/A

Issues resolved

N/A

Documentation

N/A

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Backwards compatibility

  • Add backport-to-stable label if the code is backwards compatible. Otherwise, list breaking changes.

Deconstruct the FilterChainMatch configurer so that match fields can
be populated individually. Renamed the source address matcher to be
consistent with the rest of the API.

Signed-off-by: James Peach <james.peach@konghq.com>
@jpeach jpeach requested a review from a team as a code owner October 28, 2021 23:58
@codecov-commenter
Copy link

Codecov Report

Merging #3037 (09a2f8a) into master (db4f9b0) will increase coverage by 0.02%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3037      +/-   ##
==========================================
+ Coverage   52.32%   52.35%   +0.02%     
==========================================
  Files         919      919              
  Lines       52989    53024      +35     
==========================================
+ Hits        27727    27759      +32     
+ Misses      23053    23051       -2     
- Partials     2209     2214       +5     
Impacted Files Coverage Δ
...kg/xds/envoy/listeners/filter_chain_configurers.go 97.10% <ø> (-0.20%) ⬇️
pkg/xds/envoy/listeners/v3/configurer.go 66.66% <50.00%> (-7.02%) ⬇️
.../envoy/listeners/filter_chain_match_configurers.go 87.50% <87.50%> (ø)
pkg/xds/generator/admin_proxy_generator.go 86.79% <100.00%> (ø)
pkg/xds/generator/inbound_proxy_generator.go 76.27% <100.00%> (+1.49%) ⬆️
pkg/xds/generator/ingress_generator.go 85.85% <100.00%> (+0.29%) ⬆️
pkg/xds/generator/prometheus_endpoint_generator.go 91.20% <100.00%> (+0.40%) ⬆️
...nvoy/listeners/v3/filter_chain_match_configurer.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/plugins/leader/postgres/leader_elector.go 93.61% <0.00%> (-4.26%) ⬇️
pkg/core/resources/manager/cache.go 83.11% <0.00%> (-2.60%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db4f9b0...09a2f8a. Read the comment docs.

@jpeach jpeach merged commit 45e6e21 into kumahq:master Nov 2, 2021
mergify bot pushed a commit that referenced this pull request Nov 2, 2021
Deconstruct the FilterChainMatch configurer so that match fields can
be populated individually. Renamed the source address matcher to be
consistent with the rest of the API.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 45e6e21)
jpeach added a commit that referenced this pull request Nov 2, 2021
)

Deconstruct the FilterChainMatch configurer so that match fields can
be populated individually. Renamed the source address matcher to be
consistent with the rest of the API.

Signed-off-by: James Peach <james.peach@konghq.com>
(cherry picked from commit 45e6e21)

Co-authored-by: James Peach <james.peach@konghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants